Skip to content

Conversation

@skuhlmann
Copy link
Contributor

@skuhlmann skuhlmann commented Nov 25, 2025

Summary by CodeRabbit

  • Bug Fixes

    • Corrected event tracking call formatting.
    • Removed debug output from event handlers.
    • Simplified legacy event listener setup.
  • Refactor

    • Enhanced layout organization in the Our Story section.
    • Added callback support for form wizard step completion.

✏️ Tip: You can customize this high-level summary in your review settings.

@vercel
Copy link

vercel bot commented Nov 25, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
website Ready Ready Preview Comment Nov 25, 2025 9:39pm

@coderabbitai
Copy link

coderabbitai bot commented Nov 25, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Telemetry instrumentation enhancements across the website. Bug fixes to Fathom component (console log removal, event payload formatting). Data-click attributes added to interactive elements for analytics tracking. Event tracking integrated into form submissions and multi-step wizard flows. Wizard component API extended with optional step completion callbacks.

Changes

Cohort / File(s) Summary
Fathom Analytics Infrastructure
src/components/Fathom.tsx
Removed debug console log, removed commented legacy wrapper, fixed trackEvent call format from link: ${tag}} to link: ${tag}.
Event Tracking Integration
src/components/HireUs.tsx, src/components/JoinUs.tsx
Added trackEvent calls on successful form submissions (hire-us-submission, join-us-submission) and per-step completion tracking in wizard (hire-us-step-1, hire-us-step-2).
Analytics Data Attributes
src/components/Header.tsx, src/components/HomeHero.tsx, src/components/MercenariesSection.tsx
Added data-click attributes to interactive elements including navigation links, home links, buttons, and logo elements for telemetry.
Layout & Structure Reorganization
src/components/OurStorySection.tsx
Reorganized grid layout to group "Our Story" content and TimelineAccordion in left column; relocated "Join the Guild" section with updated button structure and Discord link handling; added data-click attributes to action buttons.
Wizard API Extension
src/components/ui/wizard.tsx
Added optional onStepComplete?: () => void callback to WizardStep interface; invoked on successful step validation in goToStep method.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • OurStorySection.tsx layout restructuring — Verify grid column reorganization and button/link refactoring maintain intended layout and navigation behavior
  • Wizard callback integration — Confirm onStepComplete callback is properly invoked only on successful step validation
  • Event naming consistency — Ensure all tracking event names align with analytics naming conventions across files

Possibly related PRs

Poem

🐰 With data-clicks scattered like clover in spring,
Each button and link now tell tales as they sing,
The wizard counts steps, the forms send their call,
Analytics bloom—we're tracking it all! 📊✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fathoming

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6d6dd2b and 19f0e30.

📒 Files selected for processing (8)
  • src/components/Fathom.tsx (1 hunks)
  • src/components/Header.tsx (8 hunks)
  • src/components/HireUs.tsx (4 hunks)
  • src/components/HomeHero.tsx (1 hunks)
  • src/components/JoinUs.tsx (2 hunks)
  • src/components/MercenariesSection.tsx (8 hunks)
  • src/components/OurStorySection.tsx (2 hunks)
  • src/components/ui/wizard.tsx (3 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@skuhlmann skuhlmann merged commit ab2e3c4 into main Nov 25, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants