Skip to content

Update cohort join page to link to Portal join#81

Merged
dekanbro merged 3 commits into
mainfrom
codex/cr-131-update-cohort-join-page-to-link-to-porta
Jun 4, 2026
Merged

Update cohort join page to link to Portal join#81
dekanbro merged 3 commits into
mainfrom
codex/cr-131-update-cohort-join-page-to-link-to-porta

Conversation

@raidguildbot

@raidguildbot raidguildbot commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • replace cohort join email forms with Portal join CTAs
  • add a shared Portal join URL constant
  • preserve cohort page layout while removing local email-referral submission from the join flow

Checks

  • npm run lint (passes; existing HeaderJoin unused variable warning remains)
  • npm run build (passes; existing HeaderJoin warning and metadataBase warning remain)

Closes #79

Summary by CodeRabbit

  • New Features
    • Added direct portal join button with analytics tracking for user engagement metrics
  • Refactor
    • Removed email-based referral signup flow from join components
    • Simplified component structure by eliminating referral parameter dependencies
    • Unified join experience with direct portal navigation

@vercel

vercel Bot commented Jun 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
website Ready Ready Preview, Comment Jun 4, 2026 6:28pm

Request Review

@coderabbitai

coderabbitai Bot commented Jun 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f8564cfb-6c1e-4016-ac0b-5f0819675f84

📥 Commits

Reviewing files that changed from the base of the PR and between b930ae9 and 288cfcf.

📒 Files selected for processing (5)
  • src/app/join/page.tsx
  • src/components/CohortHero.tsx
  • src/components/JoinUs.tsx
  • src/components/JoinUsSection.tsx
  • src/lib/data/constants.ts

📝 Walkthrough

Walkthrough

The PR removes embedded email referral forms from the cohort join page and replaces them with direct links to https://portal.raidguild.org/join. Referral prop threading is removed from the page hierarchy, and both CohortHero and JoinUs components are refactored to display portal-join CTAs with analytics tracking instead of email submission flows.

Changes

Cohort Join Page Portal Migration

Layer / File(s) Summary
Portal join destination constant
src/lib/data/constants.ts
New PORTAL_JOIN_URL export pointing to https://portal.raidguild.org/join provides a single reference for all component CTAs.
Remove referral prop plumbing from page hierarchy
src/app/join/page.tsx, src/components/JoinUsSection.tsx
Home page component no longer accepts searchParams for referral extraction; JoinUsSection removes referral prop forwarding and renders JoinUs without props.
Refactor CohortHero component to portal CTA
src/components/CohortHero.tsx
Component shifts from email form to portal-join button: removed form-related imports, added trackPortalJoinClick handler that logs analytics event with location: "cohort_hero" and destination: "portal_join", and replaced form UI with centered button linking to PORTAL_JOIN_URL.
Refactor JoinUs component to portal CTA
src/components/JoinUs.tsx
Component simplified from email-referral form to portal CTA wrapper: imports updated, component body reworked with trackPortalJoinClick handler, deterministic image selection retained, and UI replaced with portal-focused copy and "Begin My Quest" button navigating to PORTAL_JOIN_URL.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • raid-guild/website#68: Introduces the email-referral flow that this PR removes, modifying the same JoinUs/JoinUsSection referral prop pathway.
  • raid-guild/website#70: Earlier refactoring of CohortHero.tsx and JoinUs.tsx to implement email-only signup flow, which this PR reverses in favor of portal join.
  • raid-guild/website#30: Modifies src/components/JoinUs.tsx form UI and states, overlapping component area with this PR's form-removal refactor.

Poem

🐰 No more forms to fill, just a portal link so bright,
CohortHero and JoinUs now guide seekers to the quest site,
Analytics track their clicks with purpose and care,
PORTAL_JOIN_URL shared—one destination, fair!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: replacing cohort join page email forms with Portal join links.
Linked Issues check ✅ Passed All coding requirements from #79 are met: email forms removed, Portal join CTAs added with shared constant, and form logic cleaned up.
Out of Scope Changes check ✅ Passed All changes directly support the objective to replace email forms with Portal join CTAs; no unrelated modifications detected.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/cr-131-update-cohort-join-page-to-link-to-porta

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/app/join/page.tsx

ESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox.

src/components/CohortHero.tsx

ESLint skipped: the ESLint configuration for this file references a package that is not available in the sandbox.

src/components/JoinUs.tsx

ESLint skipped: the ESLint configuration for this file references a package that is not available in the sandbox.

  • 2 others

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dekanbro dekanbro merged commit 499e1e4 into main Jun 4, 2026
3 checks passed
@dekanbro dekanbro deleted the codex/cr-131-update-cohort-join-page-to-link-to-porta branch June 4, 2026 18:52
@coderabbitai coderabbitai Bot mentioned this pull request Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update cohort join page to link to Portal join

2 participants