-
Notifications
You must be signed in to change notification settings - Fork 19
Replace Merkle trees with lists #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Why do we have the contract sources duplicated in the spec? |
|
@LefterisJP for generating API docs. |
|
So for this page? https://raiden-network-specification.readthedocs.io/en/latest/smart_contracts.html I know it's a big change and not something to focus on now but perhaps it would make sense to have the |
|
@LefterisJP I think that's a reasonalbe solution but it's for the team to decide: #235 |
following the recent change to the contracts raiden-network/raiden-contracts#1062
czepluch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address my questions. I just have one thing that I am uncertain about. Other than that it looks good and will approve when you have clarified. Thanks!
Responding to @czepluch's comments raiden-network#234 (comment)
czepluch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the changes. Looks good to me.
following the recent change to the contracts
raiden-network/raiden-contracts#1062