Skip to content

Adds instant validation feedback on input fields#109

Merged
manuelwedler merged 3 commits intoraiden-network:masterfrom
manuelwedler:instant-validation-feedback
Jul 11, 2019
Merged

Adds instant validation feedback on input fields#109
manuelwedler merged 3 commits intoraiden-network:masterfrom
manuelwedler:instant-validation-feedback

Conversation

@manuelwedler
Copy link
Copy Markdown
Contributor

Closes #103

@manuelwedler manuelwedler force-pushed the instant-validation-feedback branch from 67ed7f3 to 2446c6e Compare July 9, 2019 16:00
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 9, 2019

Codecov Report

Merging #109 into master will increase coverage by 0.3%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #109     +/-   ##
=========================================
+ Coverage   80.72%   81.03%   +0.3%     
=========================================
  Files          70       70             
  Lines        1837     1840      +3     
  Branches      199      201      +2     
=========================================
+ Hits         1483     1491      +8     
+ Misses        313      309      -4     
+ Partials       41       40      -1
Impacted Files Coverage Δ
...pp/components/token-input/token-input.component.ts 87.61% <100%> (+5.09%) ⬆️
src/testing/interaction-helper.ts 90.62% <100%> (+0.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f263dfd...2c65389. Read the comment docs.

Copy link
Copy Markdown
Contributor

@kelsos kelsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you.

@manuelwedler manuelwedler force-pushed the instant-validation-feedback branch from 5301cbc to 2c65389 Compare July 11, 2019 15:43
@manuelwedler manuelwedler merged commit 53fa591 into raiden-network:master Jul 11, 2019
@manuelwedler manuelwedler deleted the instant-validation-feedback branch July 11, 2019 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Instant validation feedback on payment dialog inputs

2 participants