Skip to content

Marks balance of new channels as awaiting while deposit is pending#180

Merged
kelsos merged 3 commits intoraiden-network:masterfrom
manuelwedler:mark-pending-channel-balance
Oct 22, 2019
Merged

Marks balance of new channels as awaiting while deposit is pending#180
kelsos merged 3 commits intoraiden-network:masterfrom
manuelwedler:mark-pending-channel-balance

Conversation

@manuelwedler
Copy link
Copy Markdown
Contributor

Closes #83

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 16, 2019

Codecov Report

Merging #180 into master will increase coverage by 0.01%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
+ Coverage   85.57%   85.59%   +0.01%     
==========================================
  Files          82       82              
  Lines        1754     1763       +9     
  Branches      222      225       +3     
==========================================
+ Hits         1501     1509       +8     
  Misses        208      208              
- Partials       45       46       +1
Impacted Files Coverage Δ
src/app/services/raiden.service.ts 90.22% <88.88%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1437f3...3b38b0f. Read the comment docs.

Copy link
Copy Markdown
Contributor

@andrevmatos andrevmatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Fixes API retries for development server
@manuelwedler manuelwedler force-pushed the mark-pending-channel-balance branch from c98e71b to 8b10c52 Compare October 22, 2019 08:35
@manuelwedler manuelwedler force-pushed the mark-pending-channel-balance branch from 8b10c52 to 95e8b2d Compare October 22, 2019 08:51
@manuelwedler manuelwedler force-pushed the mark-pending-channel-balance branch from 95e8b2d to 3b38b0f Compare October 22, 2019 09:12
@kelsos kelsos merged commit a89f7ef into raiden-network:master Oct 22, 2019
@manuelwedler manuelwedler deleted the mark-pending-channel-balance branch October 22, 2019 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mark the balance as awaiting for newly opened channels while the deposit is pending

3 participants