Skip to content

Adds showing the error screen when API is down#210

Merged
manuelwedler merged 3 commits intoraiden-network:masterfrom
manuelwedler:api-error-screen
Dec 12, 2019
Merged

Adds showing the error screen when API is down#210
manuelwedler merged 3 commits intoraiden-network:masterfrom
manuelwedler:api-error-screen

Conversation

@manuelwedler
Copy link
Copy Markdown
Contributor

Closes #18
Fixes #190

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 6, 2019

Codecov Report

Merging #210 into master will increase coverage by 0.2%.
The diff coverage is 96.29%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #210     +/-   ##
=========================================
+ Coverage   86.47%   86.67%   +0.2%     
=========================================
  Files          82       82             
  Lines        1811     1839     +28     
  Branches      242      247      +5     
=========================================
+ Hits         1566     1594     +28     
  Misses        199      199             
  Partials       46       46
Impacted Files Coverage Δ
...c/app/services/pending-transfer-polling.service.ts 97.22% <ø> (ø) ⬆️
...nents/payment-history/payment-history.component.ts 93.47% <ø> (ø) ⬆️
src/app/services/channel-polling.service.ts 100% <ø> (ø) ⬆️
...omponents/token-network/token-network.component.ts 48.62% <ø> (ø) ⬆️
src/app/components/error/error.component.ts 100% <100%> (ø) ⬆️
src/app/interceptors/error-handling.interceptor.ts 89.18% <100%> (+1.68%) ⬆️
src/app/services/raiden.service.ts 90.52% <100%> (+0.47%) ⬆️
src/app/services/notification.service.ts 100% <100%> (ø) ⬆️
src/app/services/raiden.config.ts 96% <100%> (+0.16%) ⬆️
src/testing/mock-config.ts 81.81% <100%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25f5986...ccfcf73. Read the comment docs.

Copy link
Copy Markdown
Contributor

@andrevmatos andrevmatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@manuelwedler manuelwedler merged commit b7ff191 into raiden-network:master Dec 12, 2019
@manuelwedler manuelwedler deleted the api-error-screen branch December 12, 2019 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WebUI doesn't properly update the account details Gracefully handle when the REST API is down

2 participants