Skip to content

Adds withdraw functionality#98

Merged
kelsos merged 4 commits intoraiden-network:masterfrom
kelsos:add_withdraw_functionality
Jun 28, 2019
Merged

Adds withdraw functionality#98
kelsos merged 4 commits intoraiden-network:masterfrom
kelsos:add_withdraw_functionality

Conversation

@kelsos
Copy link
Copy Markdown
Contributor

@kelsos kelsos commented Jun 14, 2019

Repurposes the deposit dialog to act also like a withdraw dialog.

Closes #94

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 14, 2019

Codecov Report

Merging #98 into master will increase coverage by 0.55%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
+ Coverage   79.01%   79.57%   +0.55%     
==========================================
  Files          69       70       +1     
  Lines        1811     1826      +15     
  Branches      196      198       +2     
==========================================
+ Hits         1431     1453      +22     
+ Misses        340      332       -8     
- Partials       40       41       +1
Impacted Files Coverage Δ
...thdraw-dialog/deposit-withdraw-dialog.component.ts 77.77% <100%> (ø)
...nents/channel-actions/channel-actions.component.ts 100% <100%> (ø) ⬆️
src/app/services/raiden.service.ts 50.93% <100%> (+5.7%) ⬆️
src/app/utils/helpers.ts 100% <100%> (ø)
src/testing/test-data.ts 100% <100%> (ø) ⬆️
...omponents/channel-table/channel-table.component.ts 53.22% <25%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad4ce8b...c6f5efb. Read the comment docs.

@kelsos kelsos marked this pull request as ready for review June 19, 2019 16:27
@kelsos kelsos requested a review from andrevmatos June 19, 2019 16:52
Comment thread src/app/components/channel-actions/channel-actions.component.html Outdated
Copy link
Copy Markdown
Contributor

@andrevmatos andrevmatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kelsos kelsos merged commit c2d6968 into raiden-network:master Jun 28, 2019
@kelsos kelsos deleted the add_withdraw_functionality branch June 28, 2019 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement withdraw

2 participants