feat: add workflow skills#15
Merged
Merged
Conversation
…view-with-research) - review-and-fix: review a branch with a domain skill, document findings, dispatch parallel worktree agents to fix each, cherry-pick and verify - dispatch-worktree-task: dispatch a planned task to a background worktree subagent (moved from diecut, generalized) - review-with-research: review a branch with parallel code-review and research subagents (moved from diecut, generalized)
- Sharpen review-and-fix trigger to avoid overlap with review-with-research - Cross-reference between review-and-fix and dispatch-worktree-task explaining why each uses a different worktree strategy - Specify subagent types in review-with-research (Explore for review, general-purpose with sonnet for research)
- Simplify review-and-fix step 6: Task tool result provides the branch name directly, no separate lookup needed - Add .gitignore reminder for .worktrees/ in dispatch-worktree-task and review-with-research
Fix 3 bugs, 6 design issues, and 2 minor issues found during audit of dispatch-worktree-task, review-and-fix, and review-with-research skills. Key fixes: - Add explicit cwd instruction for subagents in manual worktrees - Handle already-checked-out branch with --detach in review-with-research - Add clean working tree prerequisite before cherry-pick - Replace "smoke test" with "reproduction command" for consistency - Add Task tool parameter tables for review-with-research subagents - Add wave sizing guidance for parallel agent dispatch - Clarify domain skill invocation (read reference files, don't invoke Skill tool) - Clarify file access patterns (git show for baseline, direct read for branch) - Make .gitignore check actionable (check and add, not just "ensure") - Add worktree cleanup step to dispatch-worktree-task
- dispatch-worktree-task: move push out of subagent to main session, add plan completeness gate, subagent failure instructions, stale worktree handling, reproduction escape hatch for refactorings - review-and-fix: fix same-file sequencing (cherry-pick before second worktree), add zero-findings early exit, wave strategy, per-cherry-pick validation, simplify findings file handling, integrate task list as dispatch manifest, add user checkpoint before push - review-with-research: add research topic derivation step, merge synthesis+verdict with reconciliation guidance, add edge case handling (empty diff, inconclusive research, contradictions), add handoff to review-and-fix
Serial review-fix loop that dispatches a reviewer agent, then a fixer agent, commits, and repeats until findings converge to zero, plateau, or hit an iteration cap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
review-and-fixon a branch with known issues