improve orphans detection when net connected to the same components#5
Merged
GeoffreyBultot merged 1 commit intomasterfrom Jul 20, 2022
Merged
improve orphans detection when net connected to the same components#5GeoffreyBultot merged 1 commit intomasterfrom
GeoffreyBultot merged 1 commit intomasterfrom
Conversation
Member
|
@GeoffreyBultot great! I tested it on 2.F.2 Netlist and it did work with me. |
AbAzaanoun
approved these changes
Jul 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
seeing the component configuration, it's appear that the issued nets was connected only to the same component.
In the .NET file generated by AD, the netlist is good => The issue is only in the script
The issue append because we update a dict. So the net_conn U91AH:24 is replaced by U901AH:25
To resolve the issue, I changed net_conns by a list and use append instead of update ad you can see on the code diff.
@fdeprey @AbAzaanoun can you review ?