Move handling of root option from serializer to adapter.

[beauby]

This option is clearly an adapter concern and it is only used in the Json adapter.

• Custom root are not subject to inflection anymore.

Most tests are failing because they are directly testing the root value on the serializers. Will fix.

[bf4]

use the serializable helper to for less words, if you want

[beauby]

Is the helper globally available? I think it should be. If so, I'll update these tests.

[bf4]

@beauby Would you clarify what root and json_key mean in context? I thought it was the root for each resource, which would mean it's per serialized resource, no? (But now that we have Serializer::type maybe that replaces this?)

[beauby]

@bf4: No, they were only referring to the root of the document, that's why I believe it's an adapter concern. For the "roots" of resources, we actually use the association's key.

[beauby]

Updated.

[bf4]

this raises a huge red flag for me. Why is this changing?

[beauby]

I believe it should not have been there in the first place. Modifying explicitly supplied options is such an antipattern. I could move this change to an other PR though.

[NullVoxPopuli]

is this still applicable?

[bf4]

Done, iirc

B mobile phone

On Mar 10, 2016, at 4:59 AM, L. Preston Sego III notifications@github.com wrote:

is this still applicable?

—
Reply to this email directly or view it on GitHub.

[remear]

Can this be closed then?

[beauby]

Seems not: https://github.com/rails-api/active_model_serializers/blob/master/lib/active_model/serializable_resource.rb#L5
As you can see, :root is not an adapter option yet.

[bf4]

@beauby I would love if you'd come back to this one. Shouldn't be to hard to finish.

[beauby]

Will take care of it over the weekend!

[beauby]

Closing in favor of #1782.