[WIP] Move root option handling to adapter #1782
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Used by adapter as resource root. | ||
| def json_key | ||
| root || _type || object.class.model_name.to_s.underscore | ||
| _type || object.class.model_name.to_s.underscore |
Member
There was a problem hiding this comment.
as https://github.com/rails-api/active_model_serializers/pull/1782/files#r66382756 I'm fine removing root as a public interface, or in the initializer, but it should still be an option to as_json
| class Serializer | ||
| # @see #serializable_hash for more details on these valid keys. | ||
| SERIALIZABLE_HASH_VALID_KEYS = [:only, :except, :methods, :include, :root].freeze | ||
| SERIALIZABLE_HASH_VALID_KEYS = [:only, :except, :methods, :include].freeze |
Member
There was a problem hiding this comment.
root still belongs here, though technically it is an option for as_json. This isn't about partitioning and need not be changed. In fact, it's an option in the ActiveModel::Serializers::JSON interface
Contributor
Author
There was a problem hiding this comment.
You're right, will revert.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
TBA
Changes
TBA
Caveats
None 😎
Related GitHub issues
#1234
Additional helpful information
Tests are currently failing because they were testing implem rather than behavior.