-
Notifications
You must be signed in to change notification settings - Fork 1.4k
RFC/WIP: Looks at what AMS would be like as a mountable rails engine #1414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Just for review, right now. Merging would require editing in various places. Generated by export RAILS_VERSION=master bundle exec rails plugin new . --full --mountable --api --skip-spring --skip-sprockets --skip-javascript --skip-gemfile --skip-git and some editing...
|
I know there's a bunch of stuff commented out or duplicated.. just focus on what the changes would be and what they'd mean, at this point, rather than if they're complete |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yard of course
# encoding: utf-8
require 'yard'
namespace :yard do
YARD::Rake::YardocTask.new(:doc) do |t|
t.stats_options = ['--list-undoc']
end
desc 'start a gem server'
task :server do
sh 'bundle exec yard server --gems'
end
desc 'use Graphviz to generate dot graph'
task :graph do
output_file = 'doc/erd.dot'
sh "bundle exec yard graph --protected --full --dependencies > #{output_file}"
puts 'open doc/erd.dot if you have graphviz installed'
end
end|
Is this something we want to pursue? |
|
I think we should.... B mobile phone
|
|
This is particular useful if we move our fixtures and controllers etc to the dummy app to both improve code organization and document an example app |
So if someone had a bug they wanted to report, they could fork this project, try to re-create the issue in here, and open a PR, proving the bug exists? I think this would be a great way to have runnable examples, too. |
Just for review, right now. Merging would require editing in various
places.
Generated by
export RAILS_VERSION=master
bundle exec rails plugin new . --full --mountable --api --skip-spring
--skip-sprockets --skip-javascript --skip-gemfile --skip-git
and some editing...
Ref: dummy server setup in #1412
for how we could pare down the dummy app if we wanted to