[Rails3] Use new WrappedDatabaseException classes and implement translate_exception. Also create our own LostConnection exception and use this for auto reconnecting logic.

Author: metaskills

activerecord-sqlserver-adapter.gemspec

@@ -20,6 +20,7 @@ Gem::Specification.new do |s|
     "lib/active_record/connection_adapters/sqlserver_adapter/core_ext/odbc.rb",
     "lib/active_record/connection_adapters/sqlserver/database_limits.rb",
     "lib/active_record/connection_adapters/sqlserver/database_statements.rb",
+    "lib/active_record/connection_adapters/sqlserver/errors.rb",
     "lib/active_record/connection_adapters/sqlserver/schema_statements.rb",
     "lib/active_record/connection_adapters/sqlserver/quoting.rb" ]
   s.test_files = [

lib/active_record/connection_adapters/sqlserver/errors.rb

@@ -0,0 +1,33 @@
+module ActiveRecord
+  
+  class LostConnection < WrappedDatabaseException
+  end
+  
+  module ConnectionAdapters
+    module Sqlserver
+      module Errors
+        
+        LOST_CONNECTION_EXCEPTIONS  = {
+          :odbc   => ['ODBC::Error'],
+          :adonet => ['TypeError','System::Data::SqlClient::SqlException']
+        }.freeze
+        
+        LOST_CONNECTION_MESSAGES    = {
+          :odbc   => [/link failure/, /server failed/, /connection was already closed/, /invalid handle/i],
+          :adonet => [/current state is closed/, /network-related/]
+        }.freeze
+        
+        
+        def lost_connection_exceptions
+          exceptions = LOST_CONNECTION_EXCEPTIONS[connection_mode]
+          @lost_connection_exceptions ||= exceptions ? exceptions.map(&:constantize) : []
+        end
+        
+        def lost_connection_messages
+          LOST_CONNECTION_MESSAGES[connection_mode]
+        end
+        
+      end
+    end
+  end
+end

lib/active_record/connection_adapters/sqlserver_adapter.rb

@@ -3,6 +3,7 @@
 require 'active_record/connection_adapters/sqlserver/core_ext/active_record'
 require 'active_record/connection_adapters/sqlserver/database_limits'
 require 'active_record/connection_adapters/sqlserver/database_statements'
+require 'active_record/connection_adapters/sqlserver/errors'
 require 'active_record/connection_adapters/sqlserver/schema_statements'
 require 'active_record/connection_adapters/sqlserver/quoting'
 require 'active_support/core_ext/kernel/requires'
@@ -165,19 +166,12 @@ class SQLServerAdapter < AbstractAdapter
       include Sqlserver::DatabaseStatements
       include Sqlserver::SchemaStatements
       include Sqlserver::DatabaseLimits
+      include Sqlserver::Errors
 
       ADAPTER_NAME                = 'SQLServer'.freeze
-      VERSION                     = '3.0.0.beta1'.freeze
+      VERSION                     = '3.0.0.beta.1'.freeze
       DATABASE_VERSION_REGEXP     = /Microsoft SQL Server\s+(\d{4})/
       SUPPORTED_VERSIONS          = [2000,2005,2008].freeze
-      LOST_CONNECTION_EXCEPTIONS  = {
-        :odbc   => ['ODBC::Error'],
-        :adonet => ['TypeError','System::Data::SqlClient::SqlException']
-      }
-      LOST_CONNECTION_MESSAGES    = {
-        :odbc   => [/link failure/, /server failed/, /connection was already closed/, /invalid handle/i],
-        :adonet => [/current state is closed/, /network-related/]
-      }
 
       cattr_accessor :native_text_database_type, :native_binary_database_type, :native_string_database_type,
                      :log_info_schema_queries, :enable_default_unicode_types, :auto_connect
@@ -331,6 +325,21 @@ def native_binary_database_type
 
       protected
 
+      # === Abstract Adapter (Misc Support) =========================== #
+      
+      def translate_exception(e, message)
+        case message
+        when /cannot insert duplicate key .* with unique index/i
+          RecordNotUnique.new(message,e)
+        when /conflicted with the foreign key constraint/i
+          InvalidForeignKey.new(message,e)
+        when *lost_connection_messages
+          LostConnection.new(message,e)
+        else
+          super
+        end
+      end
+      
       # === SQLServer Specific (Connection Management) ================ #
 
       def connect
@@ -369,22 +378,11 @@ def remove_database_connections_and_rollback(database=nil)
         end if block_given?
       end
 
-      def lost_connection_exceptions
-        exceptions = LOST_CONNECTION_EXCEPTIONS[connection_mode]
-        @lost_connection_exceptions ||= exceptions ? exceptions.map(&:constantize) : []
-      end
-      
-      def lost_connection_messages
-        LOST_CONNECTION_MESSAGES[connection_mode]
-      end
-      
       def with_auto_reconnect
         begin
           yield
-        rescue *lost_connection_exceptions => e
-          if lost_connection_messages.any? { |lcm| e.message =~ lcm }
-            retry if auto_reconnected?
-          end
+        rescue Exception => e
+          retry if translate_exception(e,e.message).is_a?(LostConnection) && auto_reconnected?
           raise
         end
       end

test/cases/connection_test_sqlserver.rb

@@ -106,7 +106,7 @@ def setup
     should 'not auto reconnect when setting is off' do
       with_auto_connect(false) do
         @connection.disconnect!
-        assert_raise(ActiveRecord::StatementInvalid) { Topic.count }
+        assert_raise(ActiveRecord::LostConnection) { Topic.count }
       end
     end