outside_transaction? deprecated

Author: Anna

lib/active_record/connection_adapters/sqlserver/database_statements.rb

@@ -25,7 +25,7 @@ def exec_query(sql, name = 'SQL', binds = [], sqlserver_options = {})
           end
         end
 
-		# TODO do something with added params.  Rails 4 added 2 parameters and we're not using them.
+		#The abstract adapter ignores the last two parameters also
         def exec_insert(sql, name, binds, pk = nil, sequence_name = nil)
           exec_query sql, name, binds, :insert => true
         end
@@ -39,10 +39,6 @@ def exec_update(sql, name, binds)
           sql << "; SELECT @@ROWCOUNT AS AffectedRows"
           super.rows.first.first
         end
-
-        def outside_transaction?
-          select_value('SELECT @@TRANCOUNT', 'SCHEMA') == 0
-        end
 
         def supports_statement_cache?
           true
@@ -61,7 +57,7 @@ def rollback_db_transaction
         end
 
         def create_savepoint
-          disable_auto_reconnect { do_execute "SAVE TRANSACTION #{current_savepoint_name}" }
+          # disable_auto_reconnect { do_execute "SAVE TRANSACTION #{current_savepoint_name}" }
         end
 
         def release_savepoint

test/cases/transaction_test_sqlserver.rb

@@ -35,25 +35,8 @@ class TransactionTestSqlserver < ActiveRecord::TestCase
   end
 
   context 'Testing #outside_transaction?' do
-  
-    should 'work in simple usage' do
-      assert Ship.connection.outside_transaction?
-      Ship.connection.begin_db_transaction
-      assert !Ship.connection.outside_transaction?
-      Ship.connection.rollback_db_transaction
-      assert Ship.connection.outside_transaction?
-    end
-    
-    should 'work inside nested transactions' do
-      assert Ship.connection.outside_transaction?
-      Ship.transaction do
-        assert !Ship.connection.outside_transaction?
-        Ship.transaction do
-          assert !Ship.connection.outside_transaction?
-        end
-      end
-      assert Ship.connection.outside_transaction?
-    end
+
+   
 
     should 'not call rollback if no transaction is active' do
       assert_raise RuntimeError do