Skip to content

Commit 101b023

Browse files
committed
ActiveRecord's test files need to be sorted.
Even when `ActiveSupport::TestCase.test_order = :sorted` is verified. 73 failures, 52 errors, 2 skips 65 failures, 48 errors, 2 skips 63 failures, 49 errors, 2 skips 66 failures, 48 errors, 2 skips 64 failures, 47 errors, 2 skips $ bundle exec rake test ACTIVERECORD_ONLY=1 TESTOPTS="--seed=63915" 99 failures, 48 errors, 2 skips --seed 63915 99 failures, 48 errors, 2 skips --seed 63915 Using `.sort` on my ActiveRecord Rake test files helper. 65 failures, 48 errors, 2 skips 65 failures, 48 errors, 2 skips
1 parent f13fdd5 commit 101b023

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

Rakefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ namespace :test do
1212
Rake::TestTask.new(mode) do |t|
1313
t.libs = ARTest::SQLServer.test_load_paths
1414
t.test_files = test_files
15+
t.warning = !!ENV['WARNING']
1516
t.verbose = true
1617
end
1718

test/support/rake_helpers.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11

2-
TEST_HELPER = 'test/cases/helper_sqlserver.rb'
2+
SQLSERVER_TEST_HELPER = 'test/cases/helper_sqlserver.rb'
33

44
def env_ar_test_files
55
return unless ENV['AR_TEST_FILES'] && !ENV['AR_TEST_FILES'].empty?
66
@env_ar_test_files ||= begin
77
files = ENV['AR_TEST_FILES'].split(',').map do |file|
88
File.join ARTest::SQLServer.root_activerecord, file.strip
99
end
10-
files.unshift(TEST_HELPER)
10+
files.sort.unshift(SQLSERVER_TEST_HELPER)
1111
end
1212
end
1313

@@ -17,14 +17,14 @@ def env_test_files
1717
end
1818

1919
def sqlserver_cases
20-
@sqlserver_cases ||= Dir.glob('test/cases/**/*_test_sqlserver.rb') - [TEST_HELPER]
20+
@sqlserver_cases ||= Dir.glob('test/cases/**/*_test_sqlserver.rb') - [SQLSERVER_TEST_HELPER]
2121
end
2222

2323
def ar_cases
2424
@ar_cases ||= begin
2525
all_cases = Dir.glob("#{ARTest::SQLServer.root_activerecord}/test/cases/**/*_test.rb")
2626
adapters_cases = Dir.glob("#{ARTest::SQLServer.root_activerecord}/test/cases/adapters/**/*_test.rb")
27-
[TEST_HELPER] + all_cases - adapters_cases
27+
(all_cases - adapters_cases).sort.unshift(SQLSERVER_TEST_HELPER)
2828
end
2929
end
3030

0 commit comments

Comments
 (0)