Perf w/inserts. Check binds & use schema cache. Fixes #572. Thanks @noelr.

Author: metaskills

CHANGELOG.md

@@ -1,5 +1,10 @@
 ## v5.0.6
 
+#### Fixed
+
+* Performance w/inserts. Check binds & use schema cache for id inserts.
+  Fixes #572. Thanks @noelr.
+
 #### Changed
 
 * Misc index enhancements or testing. Fixes #570

lib/active_record/connection_adapters/sqlserver/database_statements.rb

@@ -20,7 +20,7 @@ def exec_query(sql, name = 'SQL', binds = [], prepare: false)
         end
 
         def exec_insert(sql, name, binds, pk = nil, _sequence_name = nil)
-          if pk && id_insert_table_name = query_requires_identity_insert?(sql)
+          if id_insert_table_name = exec_insert_requires_identity?(sql, pk, binds)
             with_identity_insert_enabled(id_insert_table_name) { exec_query(sql, name, binds) }
           else
             exec_query(sql, name, binds)
@@ -281,6 +281,30 @@ def raw_connection_do(sql)
           @update_sql = false
         end
 
+        # === SQLServer Specific (Identity Inserts) ===================== #
+
+        def exec_insert_requires_identity?(sql, pk, binds)
+          query_requires_identity_insert?(sql) if pk && binds.map(&:name).include?(pk)
+        end
+
+        def query_requires_identity_insert?(sql)
+          if insert_sql?(sql)
+            table_name = get_table_name(sql)
+            id_column = identity_columns(table_name).first
+            id_column && sql =~ /^\s*(INSERT|EXEC sp_executesql N'INSERT)[^(]+\([^)]*\b(#{id_column.name})\b,?[^)]*\)/i ? quote_table_name(table_name) : false
+          else
+            false
+          end
+        end
+
+        def insert_sql?(sql)
+          !(sql =~ /^\s*(INSERT|EXEC sp_executesql N'INSERT)/i).nil?
+        end
+
+        def identity_columns(table_name)
+          schema_cache.columns(table_name).select(&:is_identity?)
+        end
+
         # === SQLServer Specific (Selecting) ============================ #
 
         def raw_select(sql, name = 'SQL', binds = [], options = {})

lib/active_record/connection_adapters/sqlserver/schema_statements.rb

@@ -497,27 +497,6 @@ def views_real_column_name(table_name, column_name)
           match_data ? match_data[1] : column_name
         end
 
-        # === SQLServer Specific (Identity Inserts) ===================== #
-
-        def query_requires_identity_insert?(sql)
-          if insert_sql?(sql)
-            table_name = get_table_name(sql)
-            id_column = identity_columns(table_name).first
-            id_column && sql =~ /^\s*(INSERT|EXEC sp_executesql N'INSERT)[^(]+\([^)]*\b(#{id_column.name})\b,?[^)]*\)/i ? quote_table_name(table_name) : false
-          else
-            false
-          end
-        end
-
-        def insert_sql?(sql)
-          !(sql =~ /^\s*(INSERT|EXEC sp_executesql N'INSERT)/i).nil?
-        end
-
-        def identity_columns(table_name)
-          columns(table_name).select(&:is_identity?)
-        end
-
-
         private
 
         def create_table_definition(*args)

test/cases/scratchpad_test_sqlserver.rb

@@ -1,9 +1,11 @@
 require 'cases/helper_sqlserver'
+require 'models/book'
 
 class ScratchpadTestSQLServer < ActiveRecord::TestCase
 
   it 'helps debug things' do
-    #
+    $FOO = true
+    1000.times { Book.create! name: 'test' }
   end
 
 end