A bit of Ruby clarity on the new #get_indexs method, was #__indexes method.

Author: metaskills

lib/active_record/connection_adapters/sqlserver_adapter.rb

@@ -557,7 +557,7 @@ def remove_index(table_name, options = {})
 
       def indexes(table_name, name = nil)
         ActiveRecord::Base.connection.instance_variable_get("@connection")["AutoCommit"] = false
-        __indexes(table_name, name)
+        get_indexes(table_name,name)
       ensure
         ActiveRecord::Base.connection.instance_variable_get("@connection")["AutoCommit"] = true
       end
@@ -802,25 +802,26 @@ def remove_default_constraint(table_name, column_name)
       end
 
       def remove_indexes(table_name, column_name)
-        __indexes(table_name).select {|idx| idx.columns.include? column_name }.each do |idx|
-          remove_index(table_name, {:name => idx.name})
+        get_indexes(table_name).select{ |index| index.columns.include?(column_name.to_s) }.each do |index|
+          remove_index(table_name, {:name => index.name})
         end
       end
 
-      def __indexes(table_name, name = nil)
-        indexes = []
-        execute("EXEC sp_helpindex #{quote_table_name(table_name)}", name) do |handle|
-          if handle.column_info.any?
-            handle.each do |index|
-              unique = index[1] =~ /unique/
-              primary = index[1] =~ /primary key/
-              if !primary
-                indexes << IndexDefinition.new(table_name, index[0], unique, index[2].split(", ").map {|e| e.gsub('(-)','')})
-              end
+      def get_indexes(table_name, name = nil)
+        select("EXEC sp_helpindex #{quote_table_name(table_name)}",name).inject([]) do |indexes,index|
+          if index['index_description'] =~ /primary key/
+            indexes
+          else
+            name    = index['index_name']
+            unique  = index['index_description'] =~ /unique/
+            columns = index['index_keys'].split(',').map do |column|
+              column.strip!
+              column.gsub! '(-)', '' if column.ends_with?('(-)')
+              column
             end
+            indexes << IndexDefinition.new(table_name, name, unique, columns)
           end
         end
-        indexes
       end
 
       # IDENTITY INSERTS =========================================#

test/cases/adapter_test_sqlserver.rb

@@ -200,17 +200,18 @@ def setup
   context 'For indexes' do
 
     setup do
-      @connection.execute "CREATE INDEX idx_credit_limit ON accounts (credit_limit DESC)" rescue nil
+      @desc_index_name = 'idx_credit_limit_test_desc'
+      @connection.execute "CREATE INDEX #{@desc_index_name} ON accounts (credit_limit DESC)"
     end
 
     teardown do
-      @connection.execute "DROP INDEX accounts.idx_credit_limit"
+      @connection.execute "DROP INDEX accounts.#{@desc_index_name}"
     end
-
+    
     should 'have indexes with descending order' do
-      assert_equal ["credit_limit"], @connection.indexes('accounts').first.columns
+      assert @connection.indexes('accounts').detect { |i| i.name == @desc_index_name }
     end
-
+    
   end