Making sure that smalldatetime types are OK to use. Also fixed a bug in the #view_information method that checks to see if a view definition is equal to 4000 chars, meaning that it is most likely truncated and needs to use the backup method of sp_helptext to get it's view definition.

Author: metaskills

lib/active_record/connection_adapters/sqlserver_adapter.rb

@@ -485,7 +485,9 @@ def view_information(table_name)
         @sqlserver_view_information_cache[table_name] ||= begin
           view_info = info_schema_query { select_one("SELECT * FROM INFORMATION_SCHEMA.VIEWS WHERE TABLE_NAME = '#{table_name}'") }
           if view_info
-            view_info['VIEW_DEFINITION'] ||= info_schema_query { select_values("EXEC sp_helptext #{table_name}").join }
+            if view_info['VIEW_DEFINITION'].blank? || view_info['VIEW_DEFINITION'].length == 4000
+              view_info['VIEW_DEFINITION'] = info_schema_query { select_values("EXEC sp_helptext #{table_name}").join }
+            end
           end
           view_info
         end

test/cases/column_test_sqlserver.rb

@@ -158,6 +158,7 @@ def setup
       @date = SqlServerChronic.columns_hash['date']
       @time = SqlServerChronic.columns_hash['time']
       @datetime = SqlServerChronic.columns_hash['datetime']
+      @smalldatetime = SqlServerChronic.columns_hash['smalldatetime']
     end
 
     should 'have correct simplified type for uncast datetime' do
@@ -176,6 +177,23 @@ def setup
       assert_equal nil, @datetime.limit
     end
 
+    context 'For smalldatetime types' do
+      
+      should 'have created that type using rails migrations' do
+        assert_equal 'smalldatetime', @smalldatetime.sql_type
+      end
+      
+      should 'be able to insert column without truncation warnings or the like' do
+        SqlServerChronic.create! :smalldatetime => Time.now
+      end
+      
+      should 'be able to update column without truncation warnings or the like' do
+        ssc = SqlServerChronic.create! :smalldatetime => 2.days.ago
+        ssc.update_attributes! :smalldatetime => Time.now
+      end
+
+    end
+    
     context 'which have coerced types' do
 
       setup do

test/schema/sqlserver_specific_schema.rb

@@ -25,6 +25,7 @@
     t.column :time,       :time
     t.column :datetime,   :datetime
     t.column :timestamp,  :timestamp
+    t.column :smalldatetime, :smalldatetime
   end
 
   create_table(:fk_test_has_fks, :force => true) { |t| t.column(:fk_id, :integer, :null => false) }