[Azure] Core tests friendly.

Author: metaskills

lib/active_record/connection_adapters/sqlserver/database_statements.rb

@@ -179,8 +179,8 @@ def user_options_isolation_level
           if sqlserver_azure?
             sql = %(SELECT CASE [transaction_isolation_level]
                     WHEN 0 THEN NULL
-                    WHEN 1 THEN 'READ UNCOMITTED'
-                    WHEN 2 THEN 'READ COMITTED'
+                    WHEN 1 THEN 'READ UNCOMMITTED'
+                    WHEN 2 THEN 'READ COMMITTED'
                     WHEN 3 THEN 'REPEATABLE READ'
                     WHEN 4 THEN 'SERIALIZABLE'
                     WHEN 5 THEN 'SNAPSHOT' END AS [isolation_level]

test/cases/adapter_test_sqlserver.rb

@@ -240,6 +240,7 @@ class AdapterTestSQLServer < ActiveRecord::TestCase
   describe 'database statements' do
 
     it "run the database consistency checker useroptions command" do
+      skip 'on azure' if connection_sqlserver_azure?
       keys = [:textsize, :language, :isolation_level, :dateformat]
       user_options = connection.user_options
       keys.each do |key|
@@ -249,6 +250,7 @@ class AdapterTestSQLServer < ActiveRecord::TestCase
     end
 
     it "return a underscored key hash with indifferent access of the results" do
+      skip 'on azure' if connection_sqlserver_azure?
       user_options = connection.user_options
       assert_equal 'read committed', user_options['isolation_level']
       assert_equal 'read committed', user_options[:isolation_level]

test/cases/rake_test_sqlserver.rb

@@ -4,16 +4,25 @@ class SQLServerRakeTest < ActiveRecord::TestCase
 
   self.use_transactional_fixtures = false
 
+  cattr_accessor :azure_skip
+  self.azure_skip = connection_sqlserver_azure?
+
   let(:db_tasks)              { ActiveRecord::Tasks::DatabaseTasks }
   let(:new_database)          { 'activerecord_unittest_tasks' }
   let(:default_configuration) { ARTest.connection_config['arunit'] }
   let(:configuration)         { default_configuration.merge('database' => new_database) }
 
-  before do
+  before { skip 'on azure' if azure_skip }
+  before { disconnect! unless azure_skip }
+  after  { reconnect unless azure_skip }
+
+  private
+
+  def disconnect!
     connection.disconnect!
   end
 
-  after do
+  def reconnect
     ActiveRecord::Base.establish_connection(default_configuration)
     connection.drop_database(new_database) rescue nil
   end

test/cases/transaction_test_sqlserver.rb

@@ -35,14 +35,14 @@ class TransactionTestSQLServer < ActiveRecord::TestCase
     begin
       in_level = nil
       begin_level = connection.user_options_isolation_level
-      begin_level.must_match %r{read committed}
+      begin_level.must_match %r{read committed}i
       Ship.transaction(isolation: :serializable) do
         Ship.create! name: 'Black Pearl'
         in_level = connection.user_options_isolation_level
       end
       after_level = connection.user_options_isolation_level
       in_level.must_match %r{serializable}i
-      after_level.must_match %r{read committed}
+      after_level.must_match %r{read committed}i
     ensure
       connection.set_transaction_isolation_level 'READ COMMITTED'
     end