[Rails51] Remove supports_primary_key and coerce no key test.

* PrimaryKeysTest#test_create_without_primary_key_no_extra_query
* PrimaryKeysTest#test_deprecate_supports_primary_key

Author: metaskills

RAILS5-TODO.md

@@ -18,8 +18,6 @@
 * Remove deprecated tasks: `db:test:clone`, `db:test:clone_schema`, `db:test:clone_structure`.
 * Make `table_name=` reset current statement cache,
   so queries are not run against the previous table name.
-* Deprecate `supports_primary_key?` on connection adapters since it's
-  been long unused and unsupported.
 * Deprecate using `#quoted_id` in quoting.
 * Deprecate `supports_migrations?` on connection adapters.
 * Dig moving `Column#sqlserver_options` to `sql_type_metadata` delegate.

lib/active_record/connection_adapters/sqlserver_adapter.rb

@@ -77,10 +77,6 @@ def supports_migrations?
         true
       end
 
-      def supports_primary_key?
-        true
-      end
-
       def supports_ddl_transactions?
         true
       end

test/cases/coerced_tests.rb

@@ -593,6 +593,15 @@ def test_registering_new_handlers_coerced
 
 
 
+class PrimaryKeysTest < ActiveRecord::TestCase
+  # Gonna trust Rails core for this. We end up with 2 querys vs 3 asserted
+  # but as far as I can tell, this is only one for us anyway.
+  coerce_tests! :test_create_without_primary_key_no_extra_query
+end
+
+
+
+
 require 'models/task'
 class QueryCacheTest < ActiveRecord::TestCase
   coerce_tests! :test_cache_does_not_wrap_string_results_in_arrays