Add smalldatetime type for migrations. Fixes #507

Author: metaskills

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 * Performance w/inserts. Check binds & use schema cache for id inserts.
   Fixes #572. Thanks @noelr.
+* Add smalldatetime type for migrations. Fixes #507
 
 #### Changed
 

lib/active_record/connection_adapters/sqlserver/table_definition.rb

@@ -23,6 +23,10 @@ def money(*args, **options)
           args.each { |name| column(name, :money, options) }
         end
 
+        def smalldatetime(*args, **options)
+          args.each { |name| column(name, :smalldatetime, options) }
+        end
+
         def datetime(*args, **options)
           args.each do |name|
             if options[:precision]

lib/active_record/connection_adapters/sqlserver/type/smalldatetime.rb

@@ -19,7 +19,7 @@ def fast_string_to_time_format
           end
 
           def apply_seconds_precision(value)
-            value.change usec: 0
+            value.change usec: 0 if value
           end
 
         end

test/cases/schema_dumper_test_sqlserver.rb

@@ -85,6 +85,7 @@ class SchemaDumperTestSQLServer < ActiveRecord::TestCase
     # Our type methods.
     columns['real_col'].sql_type.must_equal         'real'
     columns['money_col'].sql_type.must_equal        'money'
+    columns['smalldatetime_col'].sql_type.must_equal 'smalldatetime'
     columns['datetime2_col'].sql_type.must_equal    'datetime2(7)'
     columns['datetimeoffset'].sql_type.must_equal   'datetimeoffset(7)'
     columns['smallmoney_col'].sql_type.must_equal   'smallmoney'
@@ -100,6 +101,7 @@ class SchemaDumperTestSQLServer < ActiveRecord::TestCase
     columns['json_col'].sql_type.must_equal         'nvarchar(max)'
     assert_line :real_col,          type: 'real',           limit: nil,           precision: nil,   scale: nil,  default: nil
     assert_line :money_col,         type: 'money',          limit: nil,           precision: 19,    scale: 4,    default: nil
+    assert_line :smalldatetime_col, type: 'smalldatetime',  limit: nil,           precision: nil,   scale: nil,  default: nil
     assert_line :datetime2_col,     type: 'datetime',       limit: nil,           precision: 7,     scale: nil,  default: nil
     assert_line :datetimeoffset,    type: 'datetimeoffset', limit: nil,           precision: 7,     scale: nil,  default: nil
     assert_line :smallmoney_col,    type: 'smallmoney',     limit: nil,           precision: 10,    scale: 4,    default: nil

test/schema/sqlserver_specific_schema.rb

@@ -21,6 +21,7 @@
     # Our type methods.
     t.real           :real_col
     t.money          :money_col
+    t.smalldatetime  :smalldatetime_col
     t.datetime2      :datetime2_col
     t.datetimeoffset :datetimeoffset
     t.smallmoney     :smallmoney_col