Fix schema limit reflection for char/varchar. Fixes #394.

Author: metaskills

CHANGELOG.md

@@ -2,6 +2,7 @@
 ## v4.2.4
 
 * Compatible with Rails 4.2.1.
+* Fix schema limit reflection for char/varchar. Fixes #394.
 
 
 ## v4.2.3

lib/active_record/connection_adapters/sqlserver/schema_statements.rb

@@ -235,7 +235,7 @@ def column_definitions(table_name)
             columns.DATETIME_PRECISION AS datetime_precision,
             columns.ordinal_position,
             CASE
-              WHEN columns.DATA_TYPE IN ('nchar','nvarchar') THEN columns.CHARACTER_MAXIMUM_LENGTH
+              WHEN columns.DATA_TYPE IN ('nchar','nvarchar','char','varchar') THEN columns.CHARACTER_MAXIMUM_LENGTH
               ELSE COL_LENGTH('#{database}'+columns.TABLE_SCHEMA+'.'+columns.TABLE_NAME, columns.COLUMN_NAME)
             END AS [length],
             CASE

test/cases/specific_schema_test_sqlserver.rb

@@ -5,10 +5,16 @@ class SpecificSchemaTestSQLServer < ActiveRecord::TestCase
   after { SSTestEdgeSchema.delete_all }
 
   it 'handle dollar symbols' do
-    SSTestDollarTableName.new.save
+    SSTestDollarTableName.create!
     SSTestDollarTableName.limit(20).offset(1)
   end
 
+  it 'handle dot table names' do
+    SSTestDotTableName.create! name: 'test'
+    SSTestDotTableName.limit(20).offset(1)
+    SSTestDotTableName.where(name: 'test').first.must_be :present?
+  end
+
   it 'models can use tinyint pk tables' do
     obj = SSTestTinyintPk.create! name: '1'
     obj.id.is_a? Fixnum

test/models/sqlserver/dot_table_name.rb

@@ -0,0 +1,3 @@
+class SSTestDotTableName < ActiveRecord::Base
+  self.table_name = '[dbo].[some.Name]'
+end

test/schema/sqlserver_specific_schema.rb

@@ -41,6 +41,10 @@
     t.uuid   :uuid_nil_default, default: nil
   end
 
+  create_table '[some.Name]', force: true do |t|
+    t.varchar :name
+  end
+
   create_table 'sst_my$strange_table', force: true do |t|
     t.string :name
   end