Default value detection in column_definitions is kinder to badly formatted, or long winded user defined functions, for default values. Resolves ticket #8

Author: metaskills

CHANGELOG

@@ -1,6 +1,9 @@
 
 MASTER
 
+* Default value detection in column_definitions is kinder to badly formatted, or long winded user
+  defined functions, for default values. Resolves ticket #8 [Ken Collins]
+
 * Make sure bigint SQL Server data type can be used and converted back to Bignum as expected. [Ken Collins]
 
 

lib/active_record/connection_adapters/sqlserver_adapter.rb

@@ -1081,7 +1081,8 @@ def column_definitions(table_name)
                                when nil, '(null)', '(NULL)'
                                  nil
                                else
-                                 ci[:default_value].match(/\A\(+N?'?(.*?)'?\)+\Z/)[1]
+                                 match_data = ci[:default_value].match(/\A\(+N?'?(.*?)'?\)+\Z/)
+                                 match_data ? match_data[1] : nil
                                end
           ci[:null] = ci[:is_nullable].to_i == 1 ; ci.delete(:is_nullable)
           ci