Skip to content

Commit 3106e81

Browse files
authored
Merge pull request #748 from aidanharan/fix-rake-test
Rails 6: Fix for translate_exception method signature
2 parents 98505fe + 7a1552d commit 3106e81

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

lib/active_record/connection_adapters/sqlserver/core_ext/query_methods.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@ module QueryMethods
99

1010
private
1111

12-
# Copy of original from Rails master. This patch can be removed when adapter supports Rails 6.
12+
# Copy of original from Rails master.
13+
# This patch can be removed when adapter supports Rails version greater than 6.0.2.2
1314
def table_name_matches?(from)
1415
table_name = Regexp.escape(table.name)
1516
quoted_table_name = Regexp.escape(connection.quote_table_name(table.name))

lib/active_record/connection_adapters/sqlserver_adapter.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,7 @@ def initialize_type_map(m = type_map)
325325
m.register_type 'timestamp', SQLServer::Type::Timestamp.new
326326
end
327327

328-
def translate_exception(e, message)
328+
def translate_exception(e, message:, sql:, binds:)
329329
case message
330330
when /(cannot insert duplicate key .* with unique index) | (violation of unique key constraint)/i
331331
RecordNotUnique.new(message)

0 commit comments

Comments
 (0)