Remove native string and type configs.

These are not needed and there all have easy escape hatches given AR migrations capacity to use pure SQL types.

Author: metaskills

CHANGELOG.md

@@ -14,21 +14,26 @@
   * Use `ARTest` namespace with `SQLServer` module for our helpers/objects.
   * Simple 2012 schmea addition and extensive column/type_cast object tests.
 
+#### Deprecated
 
-## v4.1.0
+* n/a
 
-* Not sure if this even happened. Just got to 4.2.0 :)
+#### Removed
 
+* SQL Server versions < 2012 which do not support OFFSET and FETCH. http://bit.ly/1B5Bwsd
+* The `enable_default_unicode_types` option. Default to national types all the time. Use SQL type name in migrations if needed.
+* Native type configs for older DB support. Includes the following with new default value.
+  * native_string_database_type => `nvarchar`
+  * native_text_database_type   => `nvarchar(max)`
+  * native_binary_database_type => `varbinary(max)`
 
-## v4.0.0
 
-* Dropped support for ruby 1.8.7
-* Removed deadlock victim retry in favor of Isolation Level
-* Removed auto_explain_threshold_in_seconds (not used in rails 4)
+#### Fixed
 
+* n/a
 
-## v3.2.12
-
+#### Security
 
+* n/a
 
 

README.md

@@ -1,4 +1,5 @@
-# ActiveRecord SQL Server Adapter. For SQL Server 2005 And Higher.
+
+# ActiveRecord SQL Server Adapter. For SQL Server 2012 And Higher.
 
 **This project is looking for a new maintainers. Join the [discusion here](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/issues/364)**
 
@@ -55,45 +56,6 @@ end
 Manually creating a `varchar(max)` is not necessary since this is the default type created when specifying a `:text` field. As time goes on we will be testing other SQL Server specific data types are handled correctly when created in a migration.
 
 
-#### Native Text/String/Binary Data Type Accessor
-
-To pass the ActiveRecord tests we had to implement an class accessor for the native type created for `:text` columns. By default any `:text` column created by migrations will create a `varchar(max)` data type. This type can be queried using the SQL = operator and has plenty of storage space which is why we made it the default. If for some reason you want to change the data type created during migrations you can configure this line to your liking in a config/initializers file.
-
-```ruby
-ActiveRecord::ConnectionAdapters::SQLServerAdapter.native_text_database_type = 'varchar(8000)'
-```
-
-Also, there is a class attribute setter for the native string database type. This is the same for all SQL Server versions, `varchar`. However it can be used instead of the #enable_default_unicode_types below for finer grain control over which types you want unicode safe when adding or changing the schema.
-
-```ruby
-ActiveRecord::ConnectionAdapters::SQLServerAdapter.native_string_database_type = 'nvarchar'
-```
-
-By default any :binary column created by migrations will create a `varbinary(max)` data type. This too can be set using an initializer.
-
-```ruby
-ActiveRecord::ConnectionAdapters::SQLServerAdapter.native_binary_database_type = 'image'
-```
-
-####  Setting Unicode Types As Default
-
-By default the adapter will use unicode safe data types for `:string` and `:text` types when defining/changing the schema! This was changed in version 3.1 since it is about time we push better unicode support and since we default to TinyTDS (DBLIB) which supports unicode queries and data. If you choose, you can set the following class attribute in a config/initializers file that will disable this behavior.
-
-```ruby
-# Default
-ActiveRecord::ConnectionAdapters::SQLServerAdapter.enable_default_unicode_types = true
-ActiveRecord::ConnectionAdapters::SQLServerAdapter.native_text_database_type = 'nvarchar(max)'
-ActiveRecord::ConnectionAdapters::SQLServerAdapter.native_string_database_type = 'nvarchar'
-
-# Disabled
-ActiveRecord::ConnectionAdapters::SQLServerAdapter.enable_default_unicode_types = false
-ActiveRecord::ConnectionAdapters::SQLServerAdapter.native_text_database_type = 'varchar(max)'
-ActiveRecord::ConnectionAdapters::SQLServerAdapter.native_string_database_type = 'varchar'
-```
-
-It is important to remember that unicode types in SQL Server have approximately half the storage capacity as their counter parts. So where a normal string would max out at (8000) a unicode string will top off at (4000).
-
-
 #### Force Schema To Lowercase
 
 Although it is not necessary, the Ruby convention is to use lowercase method names. If your database schema is in upper or mixed case, we can force all table and column names during the schema reflection process to be lowercase. Add this to your config/initializers file for the adapter.

lib/active_record/connection_adapters/sqlserver/schema_statements.rb

@@ -163,16 +163,16 @@ def views
         def initialize_native_database_types
           {
             primary_key: 'int NOT NULL IDENTITY(1,1) PRIMARY KEY',
-            string: { name: native_string_database_type, limit: 255  },
-            text: { name: native_text_database_type },
+            string: { name: 'nvarchar', limit: 255  },
+            text: { name: 'nvarchar(max)' },
             integer: { name: 'int', limit: 4 },
             float: { name: 'float', limit: 8 },
             decimal: { name: 'decimal' },
             datetime: { name: 'datetime' },
             timestamp: { name: 'datetime' },
-            time: { name: native_time_database_type },
-            date: { name: native_date_database_type },
-            binary: { name: native_binary_database_type },
+            time: { name: 'time' },
+            date: { name: 'date' },
+            binary: { name: 'varbinary(max)' },
             boolean: { name: 'bit' },
             uuid: { name: 'uniqueidentifier' },
             # These are custom types that may move somewhere else for good schema_dumper.rb hacking to output them.

lib/active_record/connection_adapters/sqlserver_adapter.rb

@@ -37,12 +37,9 @@ class SQLServerAdapter < AbstractAdapter
 
       attr_reader :database_version, :database_year, :spid, :product_level, :product_version, :edition
 
-      cattr_accessor :native_text_database_type, :native_binary_database_type, :native_string_database_type,
-                     :enable_default_unicode_types, :auto_connect, :cs_equality_operator,
+      cattr_accessor :auto_connect, :cs_equality_operator,
                      :lowercase_schema_reflection, :auto_connect_duration, :showplan_option
 
-      self.enable_default_unicode_types = true
-
       def initialize(connection, logger, pool, config)
         super(connection, logger, pool)
         # AbstractAdapter Responsibility
@@ -221,26 +218,6 @@ def auto_connect_duration
         @@auto_connect_duration ||= 10
       end
 
-      def native_string_database_type
-        @@native_string_database_type || (enable_default_unicode_types ? 'nvarchar' : 'varchar')
-      end
-
-      def native_text_database_type
-        @@native_text_database_type || enable_default_unicode_types ? 'nvarchar(max)' : 'varchar(max)'
-      end
-
-      def native_time_database_type
-        sqlserver_2005? ? 'datetime' : 'time'
-      end
-
-      def native_date_database_type
-        sqlserver_2005? ? 'datetime' : 'date'
-      end
-
-      def native_binary_database_type
-        @@native_binary_database_type || 'varbinary(max)'
-      end
-
       def cs_equality_operator
         @@cs_equality_operator || 'COLLATE Latin1_General_CS_AS_WS'
       end