Skip to content

Commit 3f66c43

Browse files
committed
[Rails51] Fix coerced tests.
1 parent 004b97f commit 3f66c43

File tree

1 file changed

+2
-11
lines changed

1 file changed

+2
-11
lines changed

test/cases/coerced_tests.rb

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -52,14 +52,14 @@ def test_value_limit_violations_are_translated_to_specific_exception_coerced
5252

5353
require 'models/topic'
5454
class AttributeMethodsTest < ActiveRecord::TestCase
55-
coerce_tests! :test_typecast_attribute_from_select_to_false
55+
coerce_tests! %r{typecast attribute from select to false}
5656
def test_typecast_attribute_from_select_to_false_coerced
5757
Topic.create(:title => 'Budget')
5858
topic = Topic.all.merge!(:select => "topics.*, IIF (1 = 2, 1, 0) as is_test").first
5959
assert !topic.is_test?
6060
end
6161

62-
coerce_tests! :test_typecast_attribute_from_select_to_true
62+
coerce_tests! %r{typecast attribute from select to true}
6363
def test_typecast_attribute_from_select_to_true_coerced
6464
Topic.create(:title => 'Budget')
6565
topic = Topic.all.merge!(:select => "topics.*, IIF (1 = 1, 1, 0) as is_test").first
@@ -375,12 +375,6 @@ def test_exists_does_not_select_columns_without_alias_coerced
375375
end
376376
end
377377

378-
coerce_tests! :test_string_sanitation
379-
def test_string_sanitation_coerced
380-
assert_not_equal "'something ' 1=1'", ActiveRecord::Base.sanitize("something ' 1=1")
381-
assert_equal "N'something; select table'", ActiveRecord::Base.sanitize("something; select table")
382-
end
383-
384378
coerce_tests! :test_take_and_first_and_last_with_integer_should_use_sql_limit
385379
def test_take_and_first_and_last_with_integer_should_use_sql_limit_coerced
386380
assert_sql(/OFFSET 0 ROWS FETCH NEXT @0 ROWS ONLY.* @0 = 3/) { Topic.take(3).entries }
@@ -650,9 +644,6 @@ def test_schema_dump_keeps_large_precision_integer_columns_as_decimal_coerced
650644
assert_match %r{t.decimal\s+"atoms_in_universe",\s+precision: 38}, output
651645
end
652646

653-
# This accidently returns the wrong number because of our tables too.
654-
coerce_tests! :test_types_line_up
655-
656647
# This is a poorly written test and really does not catch the bottom'ness it is meant too. Ours throw it off.
657648
coerce_tests! :test_foreign_keys_are_dumped_at_the_bottom_to_circumvent_dependency_issues
658649

0 commit comments

Comments
 (0)