Enable ordering count subquery

matthewdunbar · matthewdunbar · commit 445837c22ed2 · 2018-07-06T19:29:48.000-04:00
diff --git a/lib/active_record/connection_adapters/sqlserver/core_ext/calculations.rb b/lib/active_record/connection_adapters/sqlserver/core_ext/calculations.rb
@@ -18,7 +18,7 @@ def build_count_subquery(relation, column_name, distinct)
               end
             ]
 
-            relation = relation.unscope(:order)
+            relation = relation.offset(0)
             subquery = relation.arel.as(Arel.sql("subquery_for_count"))
             select_value = operation_over_aggregate_column(column_alias || Arel.star, "count", false)
 

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ def build_count_subquery(relation, column_name, distinct)`
`18`	`18`	`end`
`19`	`19`	`]`
`20`	`20`
`21`		`- relation = relation.unscope(:order)`
	`21`	`+ relation = relation.offset(0)`
`22`	`22`	`subquery = relation.arel.as(Arel.sql("subquery_for_count"))`
`23`	`23`	`select_value = operation_over_aggregate_column(column_alias \|\| Arel.star, "count", false)`
`24`	`24`