Fixed bugs exposed by core ActiveRecord tests.

√ 22 - RuntimeError: unsupported: String
       lib/arel/visitors/to_sql.rb:729:in `unsupported'

Author: metaskills

CHANGELOG.md

@@ -16,6 +16,7 @@
   * Use `ARTest` namespace with `SQLServer` module for our helpers/objects.
   * Simple 2012 schmea addition and extensive column/type_cast object tests.
 * Follow Rails convention and remove varying character default limits.
+* The `cs_equality_operator` is now s class configuration property only.
 
 #### Deprecated
 

lib/active_record/connection_adapters/sqlserver/database_statements.rb

@@ -75,7 +75,8 @@ def empty_insert_statement_value
         end
 
         def case_sensitive_modifier(node, table_attribute)
-          node.acts_like?(:string) ? Arel::Nodes::Bin.new(node) : node
+          node = Arel::Nodes.build_quoted node, table_attribute
+          Arel::Nodes::Bin.new(node)
         end
 
         # === SQLServer Specific ======================================== #

lib/active_record/connection_adapters/sqlserver_adapter.rb

@@ -38,7 +38,10 @@ class SQLServerAdapter < AbstractAdapter
       attr_reader :spid
 
       cattr_accessor :auto_connect, :auto_connect_duration, instance_accessor: false
-      cattr_accessor :cs_equality_operator, :lowercase_schema_reflection, :showplan_option
+      cattr_accessor :cs_equality_operator, instance_accessor: false
+      cattr_accessor :lowercase_schema_reflection, :showplan_option
+
+      self.cs_equality_operator = 'COLLATE Latin1_General_CS_AS_WS'
 
       def initialize(connection, logger, pool, config)
         super(connection, logger, pool)
@@ -181,9 +184,6 @@ def auto_connect_duration
         self.class.auto_connect_duration ||= 10
       end
 
-      def cs_equality_operator
-        @@cs_equality_operator || 'COLLATE Latin1_General_CS_AS_WS'
-      end
 
       protected
 

lib/arel/visitors/sqlserver.rb

@@ -16,6 +16,12 @@ def visit_Arel_Nodes_BindParam o, collector
         collector.add_bind(o) { |i| "@#{i-1}" }
       end
 
+      def visit_Arel_Nodes_Bin o, collector
+        visit o.expr, collector
+        collector << ActiveRecord::ConnectionAdapters::SQLServerAdapter.cs_equality_operator
+        collector << SPACE
+      end
+
       def visit_Arel_Nodes_Lock o, collector
         o.expr = Arel.sql('WITH (UPDLOCK)') if o.expr.to_s =~ /FOR UPDATE/
         collector << SPACE