Skip to content

Commit 6197f0b

Browse files
committed
TODO NOTES [ci skip]
1 parent ac64683 commit 6197f0b

File tree

1 file changed

+11
-26
lines changed

1 file changed

+11
-26
lines changed

RAILS5-TODO.md

Lines changed: 11 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,36 +1,21 @@
11

2-
## SHORT TERM
3-
4-
Misc remidners while in the heat of adapting the adpater.
5-
6-
7-
## LONG TERM
8-
9-
After we get some tests passing
10-
11-
* Check `sql_for_insert` can do without the table regular expresion.
12-
* Do we need the `query_requires_identity_insert` check in `execute`?
2+
## Rails v5.0
3+
4+
* Docs on Docker Usage & Testing - https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/issues/547
5+
* Supports JSON - https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/issues/485
6+
* Supports Comments - https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/issues/486
7+
* Supports Indexed in Create - https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/issues/483
8+
https://blog.dbi-services.com/sql-server-2014-tips-create-indexes-directly-via-create-table/
9+
Column Store https://msdn.microsoft.com/en-us/library/gg492153.aspx
10+
https://www.microsoft.com/en-us/sql-server/developer-get-started/node-mac
1311
* Does the schema cache serialize properly since we conform to that now?
14-
* What does `supports_materialized_views?` means for SQL Server
15-
- http://michaeljswart.com/2014/12/materialized-views-in-sql-server/
16-
- https://blogs.msdn.microsoft.com/ssma/2011/06/20/migrating-oracle-materialized-view-to-sql-server/
17-
- http://stackoverflow.com/questions/3986366/how-to-create-materialized-views-in-sql-server
18-
* BIGINT PK support. https://github.com/rails/rails/pull/26266
1912
* Can we use `OPTIMIZE FOR UNKNOWN`
2013
- http://sqlblog.com/blogs/aaron_bertrand/archive/2011/09/17/bad-habits-to-kick-using-exec-instead-of-sp-executesql.aspx
2114
- http://stackoverflow.com/questions/24016199/sql-server-stored-procedure-become-very-slow-raw-sql-query-is-still-very-fast
2215
- https://blogs.msdn.microsoft.com/sqlprogrammability/2008/11/26/optimize-for-unknown-a-little-known-sql-server-2008-feature/
23-
* Re-visit all `current_adapter?(:PostgreSQLAdapter)` checks and find ones we can play in.
2416

2517

26-
#### Does Find By SQL Work?
18+
## Rails v5.1
2719

28-
With binds and prepareable?
20+
* BIGINT PK support. https://github.com/rails/rails/pull/26266
2921

30-
```ruby
31-
# Post.find_by_sql ["SELECT title FROM posts WHERE author = ? AND created > ?", author_id, start_date]
32-
# Post.find_by_sql ["SELECT body FROM comments WHERE author = :user_id OR approved_by = :user_id", { :user_id => user_id }]
33-
#
34-
def find_by_sql(sql, binds = [], preparable: nil)
35-
result_set = connection.select_all(sanitize_sql(sql), "#{name} Load", binds, preparable: preparable)
36-
```

0 commit comments

Comments
 (0)