Support create table with query from relation or select statement.

HasOneAssociationsTest#test_has_one_does_not_use_order_by
MigrationTest#test_create_table_with_query:

9 failures, 4 errors, 2 skips

Author: metaskills

CHANGELOG.md

@@ -7,7 +7,7 @@
 * Aliased `ActiveRecord::Type::SQLServer` to `ActiveRecord::ConnectionAdapters::SQLServer::Type`
 * New `SQLServer::Utils::Name` object for decomposing and quoting SQL Server names/identifiers.
 * Support for most all SQL Server types in schema statements and dumping.
-* Support create table with query from relation.
+* Support create table with query from relation or select statement.
 
 #### Changed
 

lib/active_record/connection_adapters/sqlserver/schema_creation.rb

@@ -16,14 +16,9 @@ def visit_ColumnDefinition(o)
 
         def visit_TableDefinition(o)
           if o.as
-            visitor = o.as.connection.visitor
-            table_name = o.temporary ? "##{o.name}" : o.name
-            select_into = "SELECT "
-            select_into << "(#{visitor.accept(o.as.arel.projections, Arel::Collectors::PlainString.new).value}) "
-            select_into << "INTO "
-            select_into << "#{quote_table_name(table_name)} "
-            select_into << "FROM "
-            select_into << "#{visitor.accept(o.as.arel.froms[0], Arel::Collectors::PlainString.new).value}"
+            table_name = quote_table_name(o.temporary ? "##{o.name}" : o.name)
+            projections, source = @conn.to_sql(o.as).match(%r{SELECT\s+(.*)?\s+FROM\s+(.*)?}).captures
+            select_into = "SELECT #{projections} INTO #{table_name} FROM #{source}"
           else
             o.instance_variable_set :@as, nil
             super

test/cases/coerced_tests.rb

@@ -291,6 +291,16 @@ def test_take_and_first_and_last_with_integer_should_use_sql_limit_coerced
 
 
 
+class HasOneAssociationsTest < ActiveRecord::TestCase
+
+  # We use OFFSET/FETCH vs TOP. So we always have an order.
+  coerce_tests! :test_has_one_does_not_use_order_by
+
+end
+
+
+
+
 require 'models/company'
 class InheritanceTest < ActiveRecord::TestCase