Fix tests

Author: aidanharan

test/cases/coerced_tests.rb

@@ -55,8 +55,9 @@ module ActiveRecord
   class AdapterTestWithoutTransaction < ActiveRecord::TestCase
     # SQL Server does not allow truncation of tables that are referenced by foreign key
     # constraints. So manually remove/add foreign keys in test.
-    coerce_tests! :test_truncate_tables
+    coerce_tests! :test_truncate_tables, :test_truncate_tables_with_query_cache
     def test_truncate_tables_coerced
+      # Remove foreign key constraint to allow truncation.
       @connection.remove_foreign_key :authors, :author_addresses
 
       assert_operator Post.count, :>, 0
@@ -69,8 +70,33 @@ def test_truncate_tables_coerced
       assert_equal 0, Author.count
       assert_equal 0, AuthorAddress.count
     ensure
+      reset_fixtures("posts", "authors", "author_addresses")
+
+      # Restore foreign key constraint.
       @connection.add_foreign_key :authors, :author_addresses
+    end
+
+    def test_truncate_tables_with_query_cache
+      # Remove foreign key constraint to allow truncation.
+      @connection.remove_foreign_key :authors, :author_addresses
+
+      @connection.enable_query_cache!
+
+      assert_operator Post.count, :>, 0
+      assert_operator Author.count, :>, 0
+      assert_operator AuthorAddress.count, :>, 0
+
+      @connection.truncate_tables("author_addresses", "authors", "posts")
+
+      assert_equal 0, Post.count
+      assert_equal 0, Author.count
+      assert_equal 0, AuthorAddress.count
+    ensure
       reset_fixtures("posts", "authors", "author_addresses")
+      @connection.disable_query_cache!
+
+      # Restore foreign key constraint.
+      @connection.add_foreign_key :authors, :author_addresses
     end
   end
 end
@@ -1209,37 +1235,9 @@ class EagerLoadingTooManyIdsTest < ActiveRecord::TestCase
 
 module ActiveRecord
   class DatabaseTasksTruncateAllTest < ActiveRecord::TestCase
-
     # SQL Server does not allow truncation of tables that are referenced by foreign key
-    # constraints. So manually remove/add foreign keys in test.
+    # constraints. As this test truncates all tables we would need to remove all foreign
+    # key constraints and then restore them afterwards to get this test to pass.
     coerce_tests! :test_truncate_tables
-    def test_truncate_tables_coerced
-      connection = ActiveRecord::Base.connection
-      connection.remove_foreign_key :authors, :author_addresses
-
-      assert_operator SchemaMigration.count, :>, 0
-      assert_operator InternalMetadata.count, :>, 0
-      assert_operator Author.count, :>, 0
-      assert_operator AuthorAddress.count, :>, 0
-
-      old_configurations = ActiveRecord::Base.configurations
-      configurations = { development: ActiveRecord::Base.configurations["arunit"] }
-      ActiveRecord::Base.configurations = configurations
-
-      ActiveRecord::Tasks::DatabaseTasks.stub(:root, nil) do
-        ActiveRecord::Tasks::DatabaseTasks.truncate_all(
-          ActiveSupport::StringInquirer.new("development")
-        )
-      end
-
-      assert_operator SchemaMigration.count, :>, 0
-      assert_operator InternalMetadata.count, :>, 0
-      assert_equal 0, Author.count
-      assert_equal 0, AuthorAddress.count
-    ensure
-      connection.add_foreign_key :authors, :author_addresses
-      ActiveRecord::Base.configurations = old_configurations
-    end
-
   end
 end