Use adapter_name instead of is_a? to detect SQLServer

Author: mattbrictson

lib/active_record/connection_adapters/sqlserver/core_ext/attribute_methods.rb

@@ -10,7 +10,7 @@ module AttributeMethods
           private
 
           def attributes_for_update(attribute_names)
-            return super unless self.class.connection.is_a?(SQLServerAdapter)
+            return super unless self.class.connection.adapter_name == "SQLServer"
 
             super.reject do |name|
               column = self.class.columns_hash[name]

lib/active_record/connection_adapters/sqlserver/core_ext/calculations.rb

@@ -10,7 +10,7 @@ module CoreExt
         module Calculations
           # Same as original except we don't perform PostgreSQL hack that removes ordering.
           def calculate(operation, column_name)
-            return super unless klass.connection.is_a?(SQLServerAdapter)
+            return super unless klass.connection.adapter_name == "SQLServer"
 
             if has_include?(column_name)
               relation = apply_join_dependency
@@ -31,7 +31,7 @@ def calculate(operation, column_name)
           private
 
           def build_count_subquery(relation, column_name, distinct)
-            return super unless klass.connection.is_a?(SQLServerAdapter)
+            return super unless klass.connection.adapter_name == "SQLServer"
 
             super(relation.unscope(:order), column_name, distinct)
           end

lib/active_record/connection_adapters/sqlserver/core_ext/explain.rb

@@ -9,7 +9,7 @@ module Explain
           SQLSERVER_STATEMENT_REGEXP = /N'(.+)', N'(.+)', (.+)/
 
           def exec_explain(queries)
-            return super unless connection.is_a?(SQLServerAdapter)
+            return super unless connection.adapter_name == "SQLServer"
 
             unprepared_queries = queries.map do |(sql, binds)|
               [unprepare_sqlserver_statement(sql, binds), binds]

lib/active_record/connection_adapters/sqlserver/core_ext/finder_methods.rb

@@ -12,7 +12,7 @@ module FinderMethods
 
           # Same as original except we order by values in distinct select if present.
           def construct_relation_for_exists(conditions)
-            return super unless klass.connection.is_a?(SQLServerAdapter)
+            return super unless klass.connection.adapter_name == "SQLServer"
 
             conditions = sanitize_forbidden_attributes(conditions)
 

lib/active_record/connection_adapters/sqlserver/core_ext/preloader.rb

@@ -10,7 +10,7 @@ module Preloader
           private
 
           def records_for(ids)
-            return super unless klass.connection.is_a?(SQLServerAdapter)
+            return super unless klass.connection.adapter_name == "SQLServer"
 
             ids.each_slice(in_clause_length).flat_map do |slice|
               scope.where(association_key_name => slice).load do |record|