Skip to content

Commit 6ea5654

Browse files
authored
Correcting tests (#725)
* corrected syntax for DEPRECATED warnings in test/cases * corrected syntax for DEPRECATED warnings in test/cases
1 parent b833393 commit 6ea5654

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

Gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ group :tinytds do
5151
end
5252

5353
group :development do
54-
gem 'byebug'
54+
gem 'byebug', platform: [:mri, :mingw, :x64_mingw]
5555
gem 'mocha'
5656
gem 'minitest-spec-rails'
5757
end

test/cases/coerced_tests.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -295,7 +295,7 @@ def test_add_column_without_limit_coerced
295295

296296
module ActiveRecord
297297
class Migration
298-
class ColumnsTest
298+
class ColumnsTest < ActiveRecord::TestCase
299299
# Our defaults are real 70000 integers vs '70000' strings.
300300
coerce_tests! :test_rename_column_preserves_default_value_not_null
301301
def test_rename_column_preserves_default_value_not_null_coerced
@@ -525,9 +525,8 @@ def test_condition_local_time_interpolation_with_default_timezone_utc_coerced
525525
end
526526
end
527527
end
528-
end
529-
530528

529+
end
531530

532531

533532
module ActiveRecord
@@ -778,6 +777,7 @@ def test_reverse_arel_assoc_order_with_function_coerced
778777
topics = Topic.order(Arel.sql("LEN(title)") => :asc).reverse_order
779778
assert_equal topics(:second).title, topics.first.title
780779
end
780+
781781
end
782782

783783
class ActiveRecord::RelationTest < ActiveRecord::TestCase

test/cases/schema_dumper_test_sqlserver.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ def assert_line(column_name, options={})
168168
if expected.nil?
169169
_(actual).must_be_nil message
170170
elsif expected.is_a?(Array)
171-
actual.must_include expected, message
171+
_(actual).must_include expected, message
172172
elsif expected.is_a?(Float)
173173
_(actual).must_be_close_to expected, 0.001
174174
elsif expected.is_a?(Proc)

0 commit comments

Comments
 (0)