Better column definitions for default objects. Fixes #412

Author: metaskills

CHANGELOG.md

@@ -5,6 +5,7 @@
 
 * Improve case comparision performace per column. Fixes #414
 * DB rollback when reversable add_column has several options. Fixes #359
+* Better column definitions for default objects. Fixes #412
 
 
 ## v4.2.4

lib/active_record/connection_adapters/sqlserver/schema_statements.rb

@@ -312,6 +312,8 @@ def column_definitions(table_name)
               when /\A\(N'(.*)'\)\Z/m
                 string_literal = SQLServer::Utils.unquote_string(Regexp.last_match[1])
                 [string_literal, nil]
+              when /CREATE DEFAULT/mi
+                [nil, nil]
               else
                 type = case ci[:type]
                        when /smallint|int|bigint/ then ci[:_type]

test/cases/specific_schema_test_sqlserver.rb

@@ -62,6 +62,12 @@ class SpecificSchemaTestSQLServer < ActiveRecord::TestCase
     assert_equal '(NULL)', default.string_with_pretend_null_four
   end
 
+  it 'default objects work' do
+    obj = SSTestObjectDefault.create! name: 'MetaSkills'
+    obj.date.must_be_nil 'since this is set on insert'
+    obj.reload.date.must_be_instance_of Date
+  end
+
   # Natural primary keys.
 
   it 'work with identity inserts' do

test/models/sqlserver/object_default.rb

@@ -0,0 +1,3 @@
+class SSTestObjectDefault < ActiveRecord::Base
+  self.table_name = 'sst_defaultobjects'
+end

test/schema/sqlserver_specific_schema.rb

@@ -109,6 +109,14 @@
     )
   TINYITPKTABLE
 
+  execute "DROP DEFAULT [sst_getdateobject];" rescue nil
+  execute "CREATE DEFAULT [sst_getdateobject] AS getdate();" rescue nil
+  create_table 'sst_defaultobjects', force: true do |t|
+    t.string :name
+    t.date   :date
+  end
+  execute "sp_bindefault 'sst_getdateobject', 'sst_defaultobjects.date'"
+
   # Constraints
 
   create_table(:sst_has_fks, force: true) { |t| t.column(:fk_id, :integer, null: false) }