More passing tests.

TransactionTest#test_releasing_named_savepoints
DefaultScopingTest#test_order_in_default_scope_should_not_prevail
RelationTest#test_order_using_scoping:
SchemaDumperDefaultsTest#test_schema_dump_defaults_with_universally_supported_types
SchemaDumperTest#test_types_line_up
SchemaDumperTest#test_schema_dump_keeps_large_precision_integer_columns_as_decimal

16 failures, 11 errors, 2 skips

Author: metaskills

lib/active_record/connection_adapters/sqlserver/type/datetime.rb

@@ -6,6 +6,10 @@ class DateTime < ActiveRecord::Type::DateTime
 
           include Castable
 
+          def type_cast_for_schema(value)
+            value.acts_like?(:string) ? "'#{value}'" : super
+          end
+
 
           private
 

lib/active_record/connection_adapters/sqlserver/type/time.rb

@@ -6,6 +6,11 @@ module SQLServer
       module Type
         class Time < ActiveRecord::Type::Time
 
+          def initialize(options = {})
+            super
+            @precision = nil if @precision == 7
+          end
+
           # When FreeTDS/TinyTDS casts this data type natively.
           # include Castable
 
@@ -14,7 +19,13 @@ def type_cast_for_database(value)
             Quoter.new super, self
           end
 
+          def type_cast_for_schema(value)
+            value.acts_like?(:string) ? "'#{value}'" : super
+          end
+
           def quote_ss(value)
+            return unless value
+            value = cast_value(value) if value.acts_like?(:string)
             date = value.to_s(:_sqlserver_time)
             frac = quote_usec(value)
             "'#{date}.#{frac}'"
@@ -34,7 +45,7 @@ def cast_usec(value)
           end
 
           def usec_to_seconds_frction(value)
-            (value.usec.to_f / 1_000_000.0).round(precision)
+            (value.usec.to_f / 1_000_000.0).round(precision || 7)
           end
 
           def quote_usec(value)

test/cases/coerced_tests.rb

@@ -147,6 +147,16 @@ module ConnectionAdapters
 
 
 
+class DefaultScopingTest < ActiveRecord::TestCase
+
+  # We are not doing order duplicate removal anymore.
+  coerce_tests! :test_order_in_default_scope_should_not_prevail
+
+end
+
+
+
+
 require 'models/post'
 require 'models/subscriber'
 class EachTest < ActiveRecord::TestCase
@@ -304,7 +314,11 @@ def test_registering_new_handlers_coerced
 
 class RelationTest < ActiveRecord::TestCase
 
-  coerce_tests! %r{doesn't have implicit ordering} # We have implicit ordering, via FETCH.
+  # We have implicit ordering, via FETCH.
+  coerce_tests! %r{doesn't have implicit ordering}
+
+  # We are not doing order duplicate removal anymore.
+  coerce_tests! :test_order_using_scoping
 
 end
 
@@ -331,7 +345,41 @@ def self.search(term)
 
 
 
+class SchemaDumperTest < ActiveRecord::TestCase
+
+  # We have precision to 38.
+  coerce_tests! :test_schema_dump_keeps_large_precision_integer_columns_as_decimal
+  def test_schema_dump_keeps_large_precision_integer_columns_as_decimal_coerced
+    output = standard_dump
+    assert_match %r{t.integer\s+"atoms_in_universe",\s+precision: 38}, output
+  end
+
+  # This accidently returns the wrong number because of our tables too.
+  coerce_tests! :test_types_line_up
+
+end
+
+
+
+require 'models/topic'
+class TransactionTest < ActiveRecord::TestCase
+
+  coerce_tests! :test_releasing_named_savepoints
+  def test_releasing_named_savepoints_coerced
+    Topic.transaction do
+      Topic.connection.create_savepoint("another")
+      Topic.connection.release_savepoint("another")
+      # We do not have a notion of releasing, so this does nothing vs raise an error.
+      Topic.connection.release_savepoint("another")
+    end
+  end
+
+end
+
+
+
 
+require 'models/tag'
 class TransactionIsolationTest < ActiveRecord::TestCase
 
   # SQL Server will lock the table for counts even when both

test/cases/column_test_sqlserver.rb

@@ -414,7 +414,7 @@ def assert_obj_set_and_save(attribute, value)
       type.type.must_equal              :time
       type.wont_be                      :number?
       type.limit.must_equal             nil
-      type.precision.must_equal         7
+      type.precision.must_equal         nil, 'so it is clean in schema dumper'
       type.scale.must_equal             nil
       # Time's #usec precision (low)
       obj.time_7 = Time.utc(2000, 01, 01, 15, 45, 00, 300)

test/cases/schema_dumper_test_sqlserver.rb

@@ -28,7 +28,7 @@ class SchemaDumperTestSQLServer < ActiveRecord::TestCase
     assert_line :datetime,          type: 'datetime',     limit: nil,           precision: nil,   scale: nil,  default: "'1753-01-01 00:00:00'"
     assert_line :smalldatetime,     type: 'datetime',     limit: nil,           precision: nil,   scale: nil,  default: "'1901-01-01 15:45:00'"
     assert_line :time_2,            type: 'time',         limit: nil,           precision: '2',   scale: nil,  default: nil
-    assert_line :time_7,            type: 'time',         limit: nil,           precision: '7',   scale: nil,  default: nil
+    assert_line :time_7,            type: 'time',         limit: nil,           precision: nil,   scale: nil,  default: nil
     # Character Strings
     assert_line :char_10,           type: 'char',         limit: '10',          precision: nil,   scale: nil,  default: "\"1234567890\""
     assert_line :varchar_50,        type: 'varchar',      limit: '50',          precision: nil,   scale: nil,  default: "\"test varchar_50\""
@@ -72,7 +72,7 @@ class SchemaDumperTestSQLServer < ActiveRecord::TestCase
     assert_line :text_col,      type: 'text',     limit: '2147483647', precision: nil,  scale: nil, default: nil
     assert_line :datetime_col,  type: 'datetime', limit: nil,          precision: nil,  scale: nil, default: nil
     assert_line :timestamp_col, type: 'datetime', limit: nil,          precision: nil,  scale: nil, default: nil
-    assert_line :time_col,      type: 'time',     limit: nil,          precision: '7',  scale: nil, default: nil
+    assert_line :time_col,      type: 'time',     limit: nil,          precision: nil,  scale: nil, default: nil
     assert_line :date_col,      type: 'date',     limit: nil,          precision: nil,  scale: nil, default: nil
     assert_line :binary_col,    type: 'binary',   limit: '2147483647', precision: nil,  scale: nil, default: nil
     # Our type methods.