Fix Misc datetimeoffset Bugs (#559)

* Allow datetimeoffset to be represented in schema.rb.
* CHANGELOG notes. [CI SKIP]

Author: metaskills

CHANGELOG.md

@@ -1,3 +1,10 @@
+## v5.0.4
+
+#### Fixed
+
+* Allow `datetimeoffset` to be used in migrations and represented in schema.
+
+
 ## v5.0.3
 
 #### Changed

VERSION

@@ -1 +1 @@
-5.0.3
+5.0.4

lib/active_record/connection_adapters/sqlserver/type/datetimeoffset.rb

@@ -4,6 +4,10 @@ module SQLServer
       module Type
         class DateTimeOffset < DateTime2
 
+          def type
+            :datetimeoffset
+          end
+
           def sqlserver_type
             "datetimeoffset(#{precision.to_i})"
           end

test/cases/column_test_sqlserver.rb

@@ -417,7 +417,7 @@ def assert_obj_set_and_save(attribute, value)
       skip 'datetimeoffset not supported in this protocal version' unless connection_dblib_73?
       col = column('datetimeoffset_7')
       col.sql_type.must_equal           'datetimeoffset(7)'
-      col.type.must_equal               :datetime
+      col.type.must_equal               :datetimeoffset
       col.null.must_equal               true
       col.default.must_equal            Time.new(1984, 01, 24, 04, 20, 00, -28800).change(nsec: 123456700), "Nanoseconds <#{col.default.nsec}> vs <123456700>"
       obj.datetimeoffset_7.must_equal   Time.new(1984, 01, 24, 04, 20, 00, -28800).change(nsec: 123456700), "Nanoseconds were <#{obj.datetimeoffset_7.nsec}> vs <999999900>"

test/cases/schema_dumper_test_sqlserver.rb

@@ -97,19 +97,20 @@ class SchemaDumperTestSQLServer < ActiveRecord::TestCase
     columns['varbinary_col'].sql_type.must_equal    'varbinary(8000)'
     columns['uuid_col'].sql_type.must_equal         'uniqueidentifier'
     columns['sstimestamp_col'].sql_type.must_equal  'timestamp'
-    assert_line :real_col,          type: 'real',         limit: nil,           precision: nil,   scale: nil,  default: nil
-    assert_line :money_col,         type: 'money',        limit: nil,           precision: 19,    scale: 4,    default: nil
-    assert_line :datetime2_col,     type: 'datetime',     limit: nil,           precision: 7,     scale: nil,  default: nil
-    assert_line :smallmoney_col,    type: 'smallmoney',   limit: nil,           precision: 10,    scale: 4,    default: nil
-    assert_line :char_col,          type: 'char',         limit: 1,             precision: nil,   scale: nil,  default: nil
-    assert_line :varchar_col,       type: 'varchar',      limit: nil,           precision: nil,   scale: nil,  default: nil
-    assert_line :text_basic_col,    type: 'text_basic',   limit: 2147483647,    precision: nil,   scale: nil,  default: nil
-    assert_line :nchar_col,         type: 'nchar',        limit: 1,             precision: nil,   scale: nil,  default: nil
-    assert_line :ntext_col,         type: 'ntext',        limit: 2147483647,    precision: nil,   scale: nil,  default: nil
-    assert_line :binary_basic_col,  type: 'binary_basic', limit: 1,             precision: nil,   scale: nil,  default: nil
-    assert_line :varbinary_col,     type: 'varbinary',    limit: nil,           precision: nil,   scale: nil,  default: nil
-    assert_line :uuid_col,          type: 'uuid',         limit: nil,           precision: nil,   scale: nil,  default: nil
-    assert_line :sstimestamp_col,   type: 'ss_timestamp', limit: nil,           precision: nil,   scale: nil,  default: nil
+    assert_line :real_col,          type: 'real',           limit: nil,           precision: nil,   scale: nil,  default: nil
+    assert_line :money_col,         type: 'money',          limit: nil,           precision: 19,    scale: 4,    default: nil
+    assert_line :datetime2_col,     type: 'datetime',       limit: nil,           precision: 7,     scale: nil,  default: nil
+    assert_line :datetimeoffset,    type: 'datetimeoffset', limit: nil,           precision: 7,     scale: nil,  default: nil
+    assert_line :smallmoney_col,    type: 'smallmoney',     limit: nil,           precision: 10,    scale: 4,    default: nil
+    assert_line :char_col,          type: 'char',           limit: 1,             precision: nil,   scale: nil,  default: nil
+    assert_line :varchar_col,       type: 'varchar',        limit: nil,           precision: nil,   scale: nil,  default: nil
+    assert_line :text_basic_col,    type: 'text_basic',     limit: 2147483647,    precision: nil,   scale: nil,  default: nil
+    assert_line :nchar_col,         type: 'nchar',          limit: 1,             precision: nil,   scale: nil,  default: nil
+    assert_line :ntext_col,         type: 'ntext',          limit: 2147483647,    precision: nil,   scale: nil,  default: nil
+    assert_line :binary_basic_col,  type: 'binary_basic',   limit: 1,             precision: nil,   scale: nil,  default: nil
+    assert_line :varbinary_col,     type: 'varbinary',      limit: nil,           precision: nil,   scale: nil,  default: nil
+    assert_line :uuid_col,          type: 'uuid',           limit: nil,           precision: nil,   scale: nil,  default: nil
+    assert_line :sstimestamp_col,   type: 'ss_timestamp',   limit: nil,           precision: nil,   scale: nil,  default: nil
   end
 
   # Special Cases