We now support your native language date/time formats automatically!

Author: metaskills

CHANGELOG

@@ -1,6 +1,10 @@
 
 * 3.1.0 *
 
+* Quote most time objects to use ISO8601 format to be multi-language dateformat compatible. The [datetime] data type is
+  automatically limited to milliseconds while [time] & [datetimeoffset] have full support. Even included a Date/Time 
+  ActiveSupport formatter that is used per the language settings of the connection.
+
 * Include a visit_Arel_Nodes_UpdateStatement method in our Arel visitor to add a limit/top for update
   that has order and no limit/top. https://github.com/rails/rails/commit/787194ee43ab1fb0a7dc8bfbbfbd5079b047d833
 

README.rdoc

@@ -7,6 +7,7 @@ The SQL Server adapter for ActiveRecord. If you need the adapter for SQL Server
 == What's New
 
 * Rails 3.1 prepared statement support leverages cached query plans.
+* We now support your native language date/time formats automatically!
 * Default unicode datatypes! Disable with #enable_default_unicode_types to false.
 * New #lowercase_schema_reflection configuration option for legacy DBs.
 * New dblib connection mode using TinyTDS! Default mode too!

lib/active_record/connection_adapters/sqlserver/quoting.rb

@@ -17,6 +17,14 @@ def quote(value, column = nil)
             else
               super
             end
+          when Date, Time
+            if column && column.sql_type == 'datetime'
+              "'#{quoted_datetime(value)}'"
+            elsif column && (column.sql_type == 'datetimeoffset' || column.sql_type == 'time')
+              "'#{quoted_full_iso8601(value)}'"
+            else
+              super
+            end
           when nil
             column.respond_to?(:sql_type) && column.sql_type == 'timestamp' ? 'DEFAULT' : super
           else
@@ -53,14 +61,39 @@ def quoted_false
           QUOTED_FALSE
         end
 
+        def quoted_datetime(value)
+          if value.acts_like?(:time)
+            value.is_a?(Date) ? quoted_value_acts_like_time_filter(value).to_time.xmlschema.to(18) : quoted_value_acts_like_time_filter(value).iso8601(3).to(22)
+          else
+            quoted_date(value)
+          end
+        end
+        
+        def quoted_full_iso8601(value)
+          if value.acts_like?(:time)
+            value.is_a?(Date) ? quoted_value_acts_like_time_filter(value).to_time.xmlschema.to(18) : quoted_value_acts_like_time_filter(value).iso8601(7).to(22)
+          else
+            quoted_date(value)
+          end
+        end
+
         def quoted_date(value)
           if value.acts_like?(:time) && value.respond_to?(:usec)
             "#{super}.#{sprintf("%03d",value.usec/1000)}"
+          elsif value.acts_like?(:date)
+            value.to_s(:_sqlserver_dateformat)
           else
             super
           end
         end
 
+        protected
+        
+        def quoted_value_acts_like_time_filter(value)
+          zone_conversion_method = ActiveRecord::Base.default_timezone == :utc ? :getutc : :getlocal
+          value.respond_to?(zone_conversion_method) ? value.send(zone_conversion_method) : value
+        end
+        
       end
     end
   end

lib/active_record/connection_adapters/sqlserver_adapter.rb

@@ -188,6 +188,7 @@ def initialize(logger,config)
                          rescue
                            0
                          end
+        initialize_dateformatter
         initialize_sqlserver_caches
         use_database
         unless SUPPORTED_VERSIONS.include?(@database_year)
@@ -410,6 +411,15 @@ def connect
         raise unless @auto_connecting
       end
 
+      def initialize_dateformatter
+        @database_dateformat = user_options['dateformat']
+        a, b, c = @database_dateformat.each_char.to_a
+        [a,b,c].each { |f| f.upcase! if f == 'y' }
+        dateformat = "%#{a}-%#{b}-%#{c}"
+        ::Date::DATE_FORMATS[:_sqlserver_dateformat] = dateformat
+        ::Time::DATE_FORMATS[:_sqlserver_dateformat] = dateformat
+      end
+      
       def remove_database_connections_and_rollback(database=nil)
         database ||= current_database
         do_execute "ALTER DATABASE #{quote_table_name(database)} SET SINGLE_USER WITH ROLLBACK IMMEDIATE"

test/cases/adapter_test_sqlserver.rb

@@ -138,13 +138,30 @@ def setup
     end
 
     context 'with different language' do
-    
+      
+      setup do
+        @default_language = @connection.user_options['language']
+      end
+      
       teardown do
+        @connection.execute("SET LANGUAGE #{@default_language}") rescue nil
+        @connection.send :initialize_dateformatter
+      end
+      
+      should 'memoize users dateformat' do
         @connection.execute("SET LANGUAGE us_english") rescue nil
+        dateformat = @connection.instance_variable_get(:@database_dateformat)
+        assert_equal 'mdy', dateformat
+      end
+      
+      should 'have a dateformatter' do
+        assert Date::DATE_FORMATS[:_sqlserver_dateformat]
+        assert Time::DATE_FORMATS[:_sqlserver_dateformat]
       end
 
-      should_eventually 'do a date insertion when language is german' do
+      should 'do a date insertion when language is german' do
         @connection.execute("SET LANGUAGE deutsch")
+        @connection.send :initialize_dateformatter
         assert_nothing_raised do
           Task.create(:starting => Time.utc(2000, 1, 31, 5, 42, 0), :ending => Date.new(2006, 12, 31))
         end
@@ -241,19 +258,13 @@ def setup
       context 'saving new datetime objects' do
 
         should 'truncate 123456 usec to just 123 in the DB cast back to 123000' do
-          @time.stubs(:usec).returns(123456)
+          Time.any_instance.stubs :iso8601 => "2011-07-26T12:29:01.123-04:00"
           saved = SqlServerChronic.create!(:datetime => @time).reload
+          saved.reload
           assert_equal '123', saved.datetime_before_type_cast.split('.')[1] if saved.datetime_before_type_cast.is_a?(String)
           assert_equal 123000, saved.datetime.usec
         end
 
-        should 'truncate 3001 usec to just 003 in the DB cast back to 3000' do
-          @time.stubs(:usec).returns(3001)
-          saved = SqlServerChronic.create!(:datetime => @time).reload
-          assert_equal '003', saved.datetime_before_type_cast.split('.')[1] if saved.datetime_before_type_cast.is_a?(String)
-          assert_equal 3000, saved.datetime.usec
-        end
-        
       end
 
     end

test/cases/persistence_test_sqlserver.rb

@@ -27,7 +27,7 @@ class PersistencesTest < ActiveRecord::TestCase
 
   include SqlserverCoercedTest
 
-  def test_update_all_doesnt_ignore_order
+  def test_coerced_update_all_doesnt_ignore_order
     assert_equal authors(:david).id + 1, authors(:mary).id
     test_update_with_order_succeeds = lambda do |order|
       begin