Implement #quoted_date correctly vs embedded logic in #quote. Still not sure if #quoted_date is needed or right way. Also #quote is lean and mean as it should be.

Author: metaskills

lib/active_record/connection_adapters/sqlserver_adapter.rb

@@ -332,24 +332,13 @@ def sqlserver_2005?
       # QUOTING ==================================================#
 
       def quote(value, column = nil)
-        return value.quoted_id if value.respond_to?(:quoted_id)
-        case value
-          when String, ActiveSupport::Multibyte::Chars
-            value = value.to_s
-            # for binary columns, don't quote the result of the string to binary
-            return column.class.string_to_binary(value) if column && column.type == :binary && column.class.respond_to?(:string_to_binary)
-            super
-          else
-            if value.acts_like?(:time)
-              "'#{value.strftime("%Y%m%d %H:%M:%S")}'"
-            elsif value.acts_like?(:date)
-              "'#{value.strftime("%Y%m%d")}'"
-            else
-              super
-            end
+        if value.kind_of?(String) && column && column.type == :binary
+          column.class.string_to_binary(value)
+        else
+          super
         end
       end
-
+      
       def quote_string(string)
         string.gsub(/\'/, "''")
       end
@@ -383,6 +372,17 @@ def quoted_false
         '0'
       end
 
+      # TODO: I get the feeling this needs to go and that it is patching something else wrong.
+      def quoted_date(value)
+        if value.acts_like?(:time)
+          value.strftime("%Y%m%d %H:%M:%S")
+        elsif value.acts_like?(:date)
+          value.strftime("%Y%m%d")
+        else
+          super
+        end
+      end
+      
       # REFERENTIAL INTEGRITY ====================================#
       # TODO: Add #disable_referential_integrity if we can use it