Document two methods for avoiding N'' quoting on char/varchar columns.

Author: metaskills

CHANGELOG.md

@@ -3,6 +3,7 @@
 #### Fixed
 
 * Undefined method `database_prefix_remote_server?' Fixes #450. Thanks @jippeholwerda
+* Document two methods for avoiding N'' quoting on char/varchar columns.
 
 
 ## v4.2.10

lib/active_record/connection_adapters/sqlserver/quoting.rb

@@ -54,12 +54,10 @@ def _quote(value)
           case value
           when Type::Binary::Data
             "0x#{value.hex}"
+          when ActiveRecord::Type::SQLServer::Char::Data
+            value.quoted
           when String, ActiveSupport::Multibyte::Chars
-            if value.is_utf8?
-              "#{QUOTED_STRING_PREFIX}#{super}"
-            else
-              super
-            end
+            "#{QUOTED_STRING_PREFIX}#{super}"
           else
             super
           end

lib/active_record/connection_adapters/sqlserver/type/char.rb

@@ -8,6 +8,18 @@ def type
             :char
           end
 
+          class Data
+
+            def initialize(value)
+              @value = value.to_s
+            end
+
+            def quoted
+              "'#{@value}'"
+            end
+
+          end
+
         end
       end
     end

test/cases/specific_schema_test_sqlserver.rb

@@ -107,6 +107,21 @@ class SpecificSchemaTestSQLServer < ActiveRecord::TestCase
     assert_equal r, SSTestEdgeSchema.where('crazy]]quote' => 'crazyqoute').first
   end
 
+  it 'various methods to bypass national quoted columns for any column, but primarily useful for char/varchar' do
+    value = Class.new do
+      def quoted_id
+        "'T'"
+      end
+    end
+    # Using ActiveRecord's quoted_id feature for objects.
+    assert_sql(/@0 = 'T'/) { SSTestDatatypeMigration.where(char_col: value.new).first }
+    assert_sql(/@0 = 'T'/) { SSTestDatatypeMigration.where(varchar_col: value.new).first }
+    # Using our custom char type data.
+    data = ActiveRecord::Type::SQLServer::Char::Data
+    assert_sql(/@0 = 'T'/) { SSTestDatatypeMigration.where(char_col: data.new('T')).first }
+    assert_sql(/@0 = 'T'/) { SSTestDatatypeMigration.where(varchar_col: data.new('T')).first }
+  end
+
   # With column names that have spaces
 
   it 'create record using a custom attribute reader and be able to load it back in' do