Skip to content

Commit b18747d

Browse files
committed
New autotest behavior defaults to adapter only. Use 'autotest railssqlserver' to test everything. Also add fixes for previous checkins on move toward better organized adapter.
1 parent 331e10b commit b18747d

File tree

5 files changed

+44
-26
lines changed

5 files changed

+44
-26
lines changed

CHANGELOG

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
2+
sqlserver_adapter.rb -- ActiveRecord adapter for Microsoft SQL Server
3+
4+
Author: Joey Gibson <joey@joeygibson.com>
5+
Date: 10/14/2004
6+
7+
Modifications: DeLynn Berry <delynnb@megastarfinancial.com>
8+
Date: 3/22/2005
9+
10+
Modifications (ODBC): Mark Imbriaco <mark.imbriaco@pobox.com>
11+
Date: 6/26/2005
12+
13+
Modifications (Migrations): Tom Ward <tom@popdog.net>
14+
Date: 27/10/2005
15+
16+
Modifications (Numerous fixes as maintainer): Ryan Tomayko <rtomayko@gmail.com>
17+
Date: Up to July 2006
18+
19+
Previous maintainer: Tom Ward <tom@popdog.net>
20+
21+
22+
23+
24+
25+
Current (interim/unofficial) maintainer: Shawn Balestracci <shawn@vegantech.com>

autotest/discover.rb

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11

22
Autotest.add_discovery do
3-
'sqlserveradapter'
3+
ARGV.first || 'sqlserver'
44
end
5-
6-

autotest/railssqlserver.rb

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
require 'autotest/sqlserver'
2+
3+
class Autotest::Railssqlserver < Autotest::Sqlserver
4+
5+
def initialize
6+
super
7+
self.libs << "#{File::PATH_SEPARATOR}../../../rails/activerecord/test/"
8+
self.extra_files = ['../../../rails/activerecord/test/']
9+
self.add_mapping %r%../../../rails/activerecord/test/.*/.*_test.rb$% do |filename, _|
10+
filename
11+
end
12+
end
13+
14+
15+
end
16+

autotest/sqlserveradapter.rb renamed to autotest/sqlserver.rb

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
require 'autotest'
22
require 'activesupport'
33

4-
class Autotest::Sqlserveradapter < Autotest
4+
class Autotest::Sqlserver < Autotest
55

66
def initialize
77
super
@@ -17,16 +17,10 @@ def initialize
1717
"../../../rails/activerecord/test/"
1818
].join(File::PATH_SEPARATOR)
1919

20-
self.extra_files = ['../../../rails/activerecord/test/']
21-
2220
self.add_mapping %r%^test/.*/.*_test_sqlserver.rb$% do |filename, _|
2321
filename
2422
end
2523

26-
self.add_mapping %r%../../../rails/activerecord/test/.*/.*_test.rb$% do |filename, _|
27-
filename
28-
end
29-
3024
end
3125

3226
# Have to use a custom reorder method since the normal :alpha for Autotest would put the

lib/active_record/connection_adapters/sqlserver_adapter.rb

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -265,21 +265,6 @@ class SQLServerAdapter < AbstractAdapter
265265

266266
ADAPTER_NAME = 'SQLServer'.freeze
267267

268-
# NATIVE_DATABASE_TYPES = {
269-
# :primary_key => "int NOT NULL IDENTITY(1, 1) PRIMARY KEY",
270-
# :string => { :name => "varchar", :limit => 255 },
271-
# :text => { :name => txt },
272-
# :integer => { :name => "int" },
273-
# :float => { :name => "float", :limit => 8 },
274-
# :decimal => { :name => "decimal" },
275-
# :datetime => { :name => "datetime" },
276-
# :timestamp => { :name => "datetime" },
277-
# :time => { :name => "datetime" },
278-
# :date => { :name => "datetime" },
279-
# :binary => { :name => bin },
280-
# :boolean => { :name => "bit"}
281-
# }
282-
283268
def initialize(connection, logger, connection_options=nil)
284269
super(connection, logger)
285270
@connection_options = connection_options
@@ -322,7 +307,7 @@ def database_version
322307
# "Microsoft SQL Server 2000 - 8.00.2039 (Intel X86) \n\tMay 3 2005 23:18:38 \n\tCopyright (c) 1988-2003 Microsoft Corporation\n\tEnterprise Edition on Windows NT 5.2 (Build 3790: )\n"
323308
# "Microsoft SQL Server 2005 - 9.00.3215.00 (Intel X86) \n\tDec 8 2007 18:51:32 \n\tCopyright (c) 1988-2005 Microsoft Corporation\n\tStandard Edition on Windows NT 5.2 (Build 3790: Service Pack 2)\n"
324309
select_value("SELECT @@version")
325-
end
310+
end
326311

327312
def supports_migrations? #:nodoc:
328313
true

0 commit comments

Comments
 (0)