Insert queries that include the word "insert" as a partial column name with the word "id" as a value were falsely being matched as identity inserts.

Author: metaskills

CHANGELOG

@@ -1,6 +1,9 @@
 
 MASTER
 
+* Insert queries that include the word "insert" as a partial column name with the word 
+  "id" as a value were falsely being matched as identity inserts. [Sean Caffery/bfabry]
+
 * Delegate all low level #raw_connection calls to #raw_connection_run and #raw_connection_do
   which abstract out the low level modes in the connection options at that point. [Ken Collins]
 

lib/active_record/connection_adapters/sqlserver_adapter.rb

@@ -942,7 +942,7 @@ def query_requires_identity_insert?(sql)
         if insert_sql?(sql)
           table_name = get_table_name(sql)
           id_column = identity_column(table_name)
-          id_column && sql =~ /INSERT[^(]+\([^)]*\b(#{id_column.name})\b,?[^)]*\)/i ? quote_table_name(table_name) : false
+          id_column && sql =~ /^\s*INSERT[^(]+\([^)]*\b(#{id_column.name})\b,?[^)]*\)/i ? quote_table_name(table_name) : false
         else
           false
         end