Preparing for ActiveRecord v3.0.4

Author: metaskills

test/cases/calculations_test_sqlserver.rb

@@ -5,12 +5,22 @@ class CalculationsTestSqlserver < ActiveRecord::TestCase
 
 class CalculationsTest < ActiveRecord::TestCase
 
-  COERCED_TESTS = [:test_should_sum_expression]
+  COERCED_TESTS = [:test_should_return_decimal_average_of_integer_field, :test_should_sum_expression]
 
   include SqlserverCoercedTest
 
   fixtures :accounts
 
+  def test_coerced_should_return_decimal_average_of_integer_field
+    # Other DBs return 3.5 like this.
+    # Account.all.map(&:id).inspect # => [1, 2, 3, 4, 5, 6]
+    # (1+2+3+4+5+6)/6.0 # => 3.5
+    # But SQL Server does something like this. Bogus!
+    # (1+2+3+4+5+6)/6 # => 3
+    value = Account.average(:id)
+    assert_equal 3, value
+  end
+  
   def test_coerced_should_sum_expression
     assert_equal 636, Account.sum("2 * credit_limit")
   end

test/cases/pessimistic_locking_test_sqlserver.rb

@@ -66,12 +66,12 @@ def setup
 
     should 'cope with eager loading un-locked paginated' do
       eager_ids_sql = /SELECT DISTINCT TOP \(5\).*FROM \[people\] WITH \(NOLOCK\)/
-      loader_sql = /FROM \[people\] WITH \(NOLOCK\).*WHERE \(\[people\].\[id\] IN/
+      loader_sql = /FROM \[people\] WITH \(NOLOCK\).*WHERE \[people\]\.\[id\] IN/
       assert_sql(eager_ids_sql,loader_sql) do
         Person.all(:include => :readers, :lock => 'WITH (NOLOCK)', :limit => 5, :offset => 10)
       end
     end
-
+    
   end