Skip to content

Commit d66ed89

Browse files
committed
Remove Type::Castable hacks for core type objects to force trust the DB. Allows Rails 5 attributes.
1 parent df8456d commit d66ed89

File tree

14 files changed

+8
-76
lines changed

14 files changed

+8
-76
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11

22
## v4.2.5
33

4+
#### Removed
5+
6+
* Remove Type::Castable hacks for core type objects to force trust the DB. Allows Rails 5 attributes.
7+
48
#### Fixed
59

610
* Tests for decimal scale. See Rails commit. http://git.io/vGotB

lib/active_record/connection_adapters/sqlserver/type.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
require 'active_record/type'
2-
require 'active_record/connection_adapters/sqlserver/type/core_ext/value.rb'
3-
require 'active_record/connection_adapters/sqlserver/type/castable.rb'
42
require 'active_record/connection_adapters/sqlserver/type/quoter.rb'
53
# Exact Numerics
64
require 'active_record/connection_adapters/sqlserver/type/integer.rb'

lib/active_record/connection_adapters/sqlserver/type/boolean.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ module SQLServer
44
module Type
55
class Boolean < ActiveRecord::Type::Boolean
66

7-
include Castable
87

98
end
109
end

lib/active_record/connection_adapters/sqlserver/type/castable.rb

Lines changed: 0 additions & 15 deletions
This file was deleted.

lib/active_record/connection_adapters/sqlserver/type/core_ext/value.rb

Lines changed: 0 additions & 39 deletions
This file was deleted.

lib/active_record/connection_adapters/sqlserver/type/date.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ module SQLServer
44
module Type
55
class Date < ActiveRecord::Type::Date
66

7-
# When FreeTDS/TinyTDS casts this data type natively.
8-
# include Castable
97

108
end
119
end

lib/active_record/connection_adapters/sqlserver/type/datetime.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ module SQLServer
44
module Type
55
class DateTime < ActiveRecord::Type::DateTime
66

7-
include Castable
8-
97
def type_cast_for_schema(value)
108
value.acts_like?(:string) ? "'#{value}'" : super
119
end

lib/active_record/connection_adapters/sqlserver/type/decimal.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ module SQLServer
44
module Type
55
class Decimal < ActiveRecord::Type::Decimal
66

7-
include Castable
87

98
end
109
end

lib/active_record/connection_adapters/sqlserver/type/float.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ module SQLServer
44
module Type
55
class Float < ActiveRecord::Type::Float
66

7-
include Castable
8-
97
def type
108
:float
119
end

lib/active_record/connection_adapters/sqlserver/type/integer.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ module SQLServer
44
module Type
55
class Integer < ActiveRecord::Type::Integer
66

7-
include Castable
87

98
end
109
end

0 commit comments

Comments
 (0)