Version 2.3.7. Correctly use :date/:time SQL types in 2008. Endow SQLServerColumn with reflection for database_year.

Author: metaskills

CHANGELOG

@@ -2,6 +2,11 @@
 MASTER
 
 
+* 2.3.7
+
+* Correctly use :date/:time SQL types in 2008 [Ken Collins]
+
+
 * 2.3.6
 
 * Allow DNS's to not contain a database and use what is in database.yml [Marco Mastrodonato]

activerecord-sqlserver-adapter.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name     = "activerecord-sqlserver-adapter"
-  s.version  = "2.3.6"
+  s.version  = "2.3.7"
   s.date     = "2010-02-17"
   s.summary  = "SQL Server 2000, 2005 and 2008 Adapter For Rails."
   s.email    = "ken@metaskills.net"

lib/active_record/connection_adapters/sqlserver_adapter.rb

@@ -109,6 +109,11 @@ def table_klass
         (@table_klass && @table_klass < ActiveRecord::Base) ? @table_klass : nil
       end
 
+      def database_year
+        @sqlserver_options[:database_year]
+      end
+      
+      
       private
 
       def extract_limit(sql_type)
@@ -140,7 +145,9 @@ def simplified_type(field_type)
       end
 
       def simplified_datetime
-        if table_klass && table_klass.coerced_sqlserver_date_columns.include?(name)
+        if database_year >= 2008
+          :datetime
+        elsif table_klass && table_klass.coerced_sqlserver_date_columns.include?(name)
           :date
         elsif table_klass && table_klass.coerced_sqlserver_time_columns.include?(name)
           :time
@@ -163,7 +170,7 @@ def simplified_datetime
     class SQLServerAdapter < AbstractAdapter
 
       ADAPTER_NAME                = 'SQLServer'.freeze
-      VERSION                     = '2.3.6'.freeze
+      VERSION                     = '2.3.7'.freeze
       DATABASE_VERSION_REGEXP     = /Microsoft SQL Server\s+(\d{4})/
       SUPPORTED_VERSIONS          = [2000,2005,2008].freeze
       LIMITABLE_TYPES             = ['string','integer','float','char','nchar','varchar','nvarchar'].freeze
@@ -265,10 +272,19 @@ def native_text_database_type
         end
       end
 
+      def native_time_database_type
+        sqlserver_2008? ? 'time' : 'datetime'
+      end
+      
+      def native_date_database_type
+        sqlserver_2008? ? 'date' : 'datetime'
+      end
+      
       def native_binary_database_type
         @@native_binary_database_type || ((sqlserver_2005? || sqlserver_2008?) ? 'varbinary(max)' : 'image')
       end
 
+      
       # QUOTING ==================================================#
 
       def quote(value, column = nil)
@@ -533,8 +549,8 @@ def native_database_types
           :decimal      => { :name => "decimal" },
           :datetime     => { :name => "datetime" },
           :timestamp    => { :name => "datetime" },
-          :time         => { :name => "datetime" },
-          :date         => { :name => "datetime" },
+          :time         => { :name => native_time_database_type },
+          :date         => { :name => native_date_database_type },
           :binary       => { :name => native_binary_database_type },
           :boolean      => { :name => "bit"},
           # These are custom types that may move somewhere else for good schema_dumper.rb hacking to output them.
@@ -606,7 +622,7 @@ def columns(table_name, name = nil)
         return [] if table_name.blank?
         cache_key = unqualify_table_name(table_name)
         @sqlserver_columns_cache[cache_key] ||= column_definitions(table_name).collect do |ci|
-          sqlserver_options = ci.except(:name,:default_value,:type,:null)
+          sqlserver_options = ci.except(:name,:default_value,:type,:null).merge(:database_year=>database_year)
           SQLServerColumn.new ci[:name], ci[:default_value], ci[:type], ci[:null], sqlserver_options
         end
       end

test/cases/column_test_sqlserver.rb

@@ -167,10 +167,15 @@ def setup
       assert_equal :datetime, @datetime.type
     end
 
-    should 'all be a datetime #sql_type' do
-      assert_equal 'datetime', @date.sql_type
-      assert_equal 'datetime', @time.sql_type
+    should 'use correct #sql_type for different sql server versions' do
       assert_equal 'datetime', @datetime.sql_type
+      if sqlserver_2000? || sqlserver_2005?
+        assert_equal 'datetime', @date.sql_type
+        assert_equal 'datetime', @time.sql_type
+      else
+        assert_equal 'date', @date.sql_type
+        assert_equal 'time', @time.sql_type
+      end
     end
 
     should 'all be have nil #limit' do
@@ -206,7 +211,7 @@ def setup
       end
 
       should 'have an inheritable attribute ' do
-        assert SqlServerChronic.coerced_sqlserver_date_columns.include?('date')
+        assert SqlServerChronic.coerced_sqlserver_date_columns.include?('date') unless sqlserver_2008?
       end
 
       should 'have column and objects cast to date' do