Fixed The ORDER BY clause is invalid in views...

HasManyAssociationsTest#test_clearing_an_association_collection:
HasManyAssociationsTest#test_clearing_without_initial_access:
HasManyAssociationsTest#test_delete_all_with_not_yet_loaded_association_collection:
HasManyAssociationsTest#test_deleting:
HasManyAssociationsTest#test_deleting_a_collection:
HasManyAssociationsTest#test_deleting_a_item_which_is_not_in_the_collection:
HasManyAssociationsTest#test_transaction_when_deleting_persisted:
HasManyAssociationsTest#test_transactions_when_replacing_on_persisted:
HasManyAssociationsTest#test_update_all_on_association_accessed_before_save:
PersistenceTest#test_update_all_ignores_order_without_limit_from_association:

69 failures, 34 errors, 2 skips

Author: metaskills

lib/arel/visitors/sqlserver.rb

@@ -25,6 +25,13 @@ def visit_Arel_Nodes_Bin o, collector
         end
       end
 
+      def visit_Arel_Nodes_UpdateStatement(o, a)
+        if o.orders.any? && o.limit.nil?
+          o.limit = Nodes::Limit.new(9_223_372_036_854_775_807)
+        end
+        super
+      end
+
       def visit_Arel_Nodes_Lock o, collector
         o.expr = Arel.sql('WITH (UPDLOCK)') if o.expr.to_s =~ /FOR UPDATE/
         collector << SPACE