Fix SQL Azure conflicts with DBCC useroptions. Use new #user_options_xyz methods. [kazamachi]

Author: metaskills

CHANGELOG

@@ -1,6 +1,8 @@
 
 * 3.1.2 *
 
+* Fix SQL Azure conflicts with DBCC useroptions. Use new #user_options_xyz methods. [kazamachi]
+
 * Fix identity inserts for tables with natural PKs. [Gian Carlo Pace]
 
 * Create a #configure_connection method that can be overridden. Think "SET TEXTSIZE...".

lib/active_record/connection_adapters/sqlserver/database_statements.rb

@@ -120,6 +120,7 @@ def use_database(database=nil)
         end
 
         def user_options
+          return {} if sqlserver_azure?
           info_schema_query do
             select_rows("dbcc useroptions").inject(HashWithIndifferentAccess.new) do |values,row| 
               set_option = row[0].gsub(/\s+/,'_')
@@ -129,10 +130,45 @@ def user_options
             end
           end
         end
+        
+        def user_options_dateformat
+          if sqlserver_azure?
+            info_schema_query { select_value "SELECT [dateformat] FROM [sys].[syslanguages] WHERE [langid] = @@LANGID" }
+          else
+            user_options['dateformat']
+          end
+        end
+        
+        def user_options_isolation_level
+          if sqlserver_azure?
+            info_schema_query do
+              sql = %|SELECT CASE [transaction_isolation_level] 
+                      WHEN 0 THEN NULL
+                      WHEN 1 THEN 'READ UNCOMITTED' 
+                      WHEN 2 THEN 'READ COMITTED' 
+                      WHEN 3 THEN 'REPEATABLE' 
+                      WHEN 4 THEN 'SERIALIZABLE' 
+                      WHEN 5 THEN 'SNAPSHOT' END AS [isolation_level] 
+                      FROM [sys].[dm_exec_sessions] 
+                      WHERE [session_id] = @@SPID|.squish
+              select_value(sql)
+            end
+          else
+            user_options['isolation_level']
+          end
+        end
+        
+        def user_options_language
+          if sqlserver_azure?
+            info_schema_query { select_value "SELECT @@LANGUAGE AS [language]" }
+          else
+            user_options['language']
+          end
+        end
 
         def run_with_isolation_level(isolation_level)
           raise ArgumentError, "Invalid isolation level, #{isolation_level}. Supported levels include #{valid_isolation_levels.to_sentence}." if !valid_isolation_levels.include?(isolation_level.upcase)
-          initial_isolation_level = user_options[:isolation_level] || "READ COMMITTED"
+          initial_isolation_level = user_options_isolation_level || "READ COMMITTED"
           do_execute "SET TRANSACTION ISOLATION LEVEL #{isolation_level}"
           begin
             yield 

lib/active_record/connection_adapters/sqlserver_adapter.rb

@@ -446,7 +446,7 @@ def configure_application_name
       end
 
       def initialize_dateformatter
-        @database_dateformat = user_options['dateformat']
+        @database_dateformat = user_options_dateformat
         a, b, c = @database_dateformat.each_char.to_a
         [a,b,c].each { |f| f.upcase! if f == 'y' }
         dateformat = "%#{a}-%#{b}-%#{c}"

test/cases/adapter_test_sqlserver.rb

@@ -140,7 +140,7 @@ def setup
     context 'with different language' do
 
       setup do
-        @default_language = @connection.user_options['language']
+        @default_language = @connection.user_options_language
       end
 
       teardown do
@@ -413,14 +413,14 @@ def setup
           @t2 = tasks(:another_task)
           assert @t1, 'Tasks :first_task should be in AR fixtures'
           assert @t2, 'Tasks :another_task should be in AR fixtures'
-          good_isolation_level = @connection.user_options[:isolation_level].blank? || @connection.user_options[:isolation_level] =~ /read committed/i
-          assert good_isolation_level, "User isolation level is not at a happy starting place: #{@connection.user_options[:isolation_level].inspect}"
+          good_isolation_level = @connection.user_options_isolation_level.blank? || @connection.user_options_isolation_level =~ /read committed/i
+          assert good_isolation_level, "User isolation level is not at a happy starting place: #{@connection.user_options_isolation_level.inspect}"
         end
 
         should 'allow #run_with_isolation_level to not take a block to set it' do
           begin
             @connection.run_with_isolation_level 'READ UNCOMMITTED'
-            assert_match %r|read uncommitted|i, @connection.user_options[:isolation_level]
+            assert_match %r|read uncommitted|i, @connection.user_options_isolation_level
           ensure
             @connection.run_with_isolation_level 'READ COMMITTED'
           end