Fixed SQL Server database tasks #1377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Could you add an entry to 'CHANGELOG.md'? |
Contributor
Author
|
Done! |
ttilberg
added a commit
to ttilberg/activerecord-sqlserver-adapter
that referenced
this pull request
Nov 11, 2025
Keeping my own fork so the branch stays stable after it's merged.
aidanharan
changed the title
Contributor
|
@justindell Thanks for the PR! Ref: rails/rails#54879 |
aidanharan
pushed a commit
that referenced
this pull request
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See rails/rails#54879.
I believe with Rails 8.1 ActiveRecord::Task classes are expected to subclass AbstractTasks.
I was seeing failures running tests on my rails app due to "NoMethodError: undefined method 'check_current_protected_environment!' for an instance of ActiveRecord::Tasks::SQLServerDatabaseTasks (NoMethodError)". This is because the check_current_protected_environment! method was moved to the AbstractTasks class.
With this change, the task db:check_protected_environments should work again.