Skip to content

Rails 6: Sanitize forbidden attributes for exists relation #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2020
Merged

Rails 6: Sanitize forbidden attributes for exists relation #751

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/active_record/connection_adapters/sqlserver/core_ext/finder_methods.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@ module FinderMethods

# Same as original except we order by values in distinct select if present.
def construct_relation_for_exists(conditions)
if distinct_value && offset_value
relation = limit!(1)
conditions = sanitize_forbidden_attributes(conditions)

if distinct_value && offset_value
if select_values.present?
relation = relation.order(*select_values)
relation = order(*select_values).limit!(1)
else
relation = relation.except(:order)
relation = except(:order).limit!(1)
end
else
relation = except(:select, :distinct, :order)._select!(::ActiveRecord::FinderMethods::ONE_AS_ONE).limit!(1)
Expand Down