Deduplicate schema cache structures #874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidanharan
force-pushed
the
mssql-schema-cache-deduplication
branch
from
bba6784 to
557a123
Compare
lavika
pushed a commit
to lavika/activerecord-sqlserver-adapter
that referenced
this pull request
Sep 26, 2023
Co-authored-by: Aidan Haran <aharan@fusioneer.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
ActiveRecord::ConnectionAdapters::SQLServer::SqlTypeMetadatato handle the schema cache deduplicateion introduced in rails/rails#35891The changes follow the same format used for the MySQL and PostgreSQL adapters.
CI on Ruby 3.0.1 before PR
https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/runs/2337409595
7133 runs, 7930 assertions, 47 failures, 3697 errors, 33 skips
CI on Ruby 3.0.1 after PR
https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/runs/2337409595
7133 runs, 9936 assertions, 41 failures, 2955 errors, 33 skips