Rails 6.1: Removed deprecated in_clause_length method #900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lavika
pushed a commit
to lavika/activerecord-sqlserver-adapter
that referenced
this pull request
Sep 26, 2023
Co-authored-by: Aidan Haran <aharan@fusioneer.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deprecated
in_clause_lengthmethod, which fixes:https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/runs/2391966961#step:4:830
Before
https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/runs/2391966961
7138 runs, 20328 assertions, 10 failures, 10 errors, 36 skips
After
https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/900/checks?check_run_id=2392463332
7138 runs, 20350 assertions, 8 failures, 10 errors, 36 skips